All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] HID: Don't hide HID drivers behind EMBEDDED
@ 2009-07-19 19:28 Henk Martijn
  2009-07-19 21:43 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Henk Martijn @ 2009-07-19 19:28 UTC (permalink / raw)
  To: jkosina, jirislaby, jussi.kivilinna, tomas.hanak, linux-kernel

When trying to minimizing my .config I found that couldn't deselect some HID drivers because they were hidden behind EMBEDDED. What's the reason?
What about the following:


---
 drivers/hid/Kconfig |   54 +++++++++++++++++++++++++-------------------------
 1 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 7831a03..274d7e2 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -71,14 +71,14 @@ menu "Special HID drivers"
 	depends on HID
 
 config HID_A4TECH
-	tristate "A4 tech" if EMBEDDED
+	tristate "A4 tech"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for A4 tech X5 and WOP-35 / Trust 450L mice.
 
 config HID_APPLE
-	tristate "Apple" if EMBEDDED
+	tristate "Apple"
 	depends on (USB_HID || BT_HIDP)
 	default !EMBEDDED
 	---help---
@@ -89,35 +89,35 @@ config HID_APPLE
 	MacBooks, MacBook Pros and Apple Aluminum.
 
 config HID_BELKIN
-	tristate "Belkin" if EMBEDDED
+	tristate "Belkin"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Belkin Flip KVM and Wireless keyboard.
 
 config HID_CHERRY
-	tristate "Cherry" if EMBEDDED
+	tristate "Cherry"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Cherry Cymotion keyboard.
 
 config HID_CHICONY
-	tristate "Chicony" if EMBEDDED
+	tristate "Chicony"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Chicony Tactical pad.
 
 config HID_CYPRESS
-	tristate "Cypress" if EMBEDDED
+	tristate "Cypress"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for cypress mouse and barcode readers.
 
 config HID_DRAGONRISE
-	tristate "DragonRise Inc. support" if EMBEDDED
+	tristate "DragonRise Inc. support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
@@ -132,35 +132,35 @@ config DRAGONRISE_FF
 	game controllers.
 
 config HID_EZKEY
-	tristate "Ezkey" if EMBEDDED
+	tristate "Ezkey"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Ezkey BTC 8193 keyboard.
 
 config HID_KYE
-	tristate "Kye" if EMBEDDED
+	tristate "Kye"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Kye/Genius Ergo Mouse.
 
 config HID_GYRATION
-	tristate "Gyration" if EMBEDDED
+	tristate "Gyration"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Gyration remote control.
 
 config HID_KENSINGTON
-	tristate "Kensington" if EMBEDDED
+	tristate "Kensington"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Kensington Slimblade Trackball.
 
 config HID_LOGITECH
-	tristate "Logitech" if EMBEDDED
+	tristate "Logitech"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
@@ -191,35 +191,35 @@ config LOGIRUMBLEPAD2_FF
 	  Rumblepad 2 devices.
 
 config HID_MICROSOFT
-	tristate "Microsoft" if EMBEDDED
+	tristate "Microsoft"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Microsoft devices that are not fully compliant with HID standard.
 
 config HID_MONTEREY
-	tristate "Monterey" if EMBEDDED
+	tristate "Monterey"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Monterey Genius KB29E.
 
 config HID_NTRIG
-	tristate "NTrig" if EMBEDDED
+	tristate "NTrig"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for N-Trig touch screen.
 
 config HID_PANTHERLORD
-	tristate "Pantherlord devices support" if EMBEDDED
+	tristate "Pantherlord devices support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for PantherLord/GreenAsia based device support.
 
 config HID_PANTHERLORD
-	tristate "Pantherlord support" if EMBEDDED
+	tristate "Pantherlord support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
@@ -235,35 +235,35 @@ config PANTHERLORD_FF
 	  or adapter and want to enable force feedback support for it.
 
 config HID_PETALYNX
-	tristate "Petalynx" if EMBEDDED
+	tristate "Petalynx"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Petalynx Maxter remote control.
 
 config HID_SAMSUNG
-	tristate "Samsung" if EMBEDDED
+	tristate "Samsung"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Samsung InfraRed remote control.
 
 config HID_SONY
-	tristate "Sony" if EMBEDDED
+	tristate "Sony"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Sony PS3 controller.
 
 config HID_SUNPLUS
-	tristate "Sunplus" if EMBEDDED
+	tristate "Sunplus"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Sunplus wireless desktop.
 
 config HID_GREENASIA
-	tristate "GreenAsia (Product ID 0x12) support" if EMBEDDED
+	tristate "GreenAsia (Product ID 0x12) support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
@@ -280,7 +280,7 @@ config GREENASIA_FF
 	and want to enable force feedback support for it.
 
 config HID_SMARTJOYPLUS
-	tristate "SmartJoy PLUS PS2/USB adapter support" if EMBEDDED
+	tristate "SmartJoy PLUS PS2/USB adapter support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
@@ -295,14 +295,14 @@ config SMARTJOYPLUS_FF
 	enable force feedback support for it.
 
 config HID_TOPSEED
-	tristate "TopSeed Cyberlink remote control support" if EMBEDDED
+	tristate "TopSeed Cyberlink remote control support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
 	Say Y if you have a TopSeed Cyberlink remote control.
 
 config HID_THRUSTMASTER
-	tristate "ThrustMaster devices support" if EMBEDDED
+	tristate "ThrustMaster devices support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
@@ -319,14 +319,14 @@ config THRUSTMASTER_FF
 	  want to enable force feedback support for it.
 
 config HID_WACOM
-	tristate "Wacom Bluetooth devices support" if EMBEDDED
+	tristate "Wacom Bluetooth devices support"
 	depends on BT_HIDP
 	default !EMBEDDED
 	---help---
 	Support for Wacom Graphire Bluetooth tablet.
 
 config HID_ZEROPLUS
-	tristate "Zeroplus based game controller support" if EMBEDDED
+	tristate "Zeroplus based game controller support"
 	depends on USB_HID
 	default !EMBEDDED
 	---help---
-- 
1.6.0.2




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: Don't hide HID drivers behind EMBEDDED
  2009-07-19 19:28 [PATCH] HID: Don't hide HID drivers behind EMBEDDED Henk Martijn
@ 2009-07-19 21:43 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2009-07-19 21:43 UTC (permalink / raw)
  To: Henk Martijn; +Cc: jirislaby, jussi.kivilinna, tomas.hanak, linux-kernel

On Sun, 19 Jul 2009, Henk Martijn wrote:

> When trying to minimizing my .config I found that couldn't deselect some 
> HID drivers because they were hidden behind EMBEDDED. What's the reason?

Hi,

mostly this is because we don't want to bother users with asking for every 
single quirky device/vendor, as there are unfortunately a lot of them. 
Usually compiling everything in doesn't waste runtime footprint (the 
modules don't get loaded unless needed), and they don't cost too much disk 
space either.
And if you really want to disable them, CONFIG_EMBEDDED allows you to do 
that.

Please see

	http://lkml.org/lkml/2008/10/14/284

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-19 21:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-19 19:28 [PATCH] HID: Don't hide HID drivers behind EMBEDDED Henk Martijn
2009-07-19 21:43 ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.