[PATCH] Only build iptables-xml when shared libraries are enabled

[PATCH] Only build iptables-xml when shared libraries are enabled

[Philip Craig]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: x --]
[-- Type: text/plain, Size: 927 bytes --]

Only build iptables-xml when shared libraries are enabled

There is no static version of iptables-xml currently.
I'm building for a target that has no libdl.

Signed-off-by: Philip Craig <philipc@snapgear.com>

diff --git a/Makefile.am b/Makefile.am
index a9e3ad3..657ef41 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -81,7 +81,7 @@ ip6tables_static_SOURCES    = ${ip6tables_multi_SOURCES} xtables.c
 ip6tables_static_CFLAGS     = ${ip6tables_multi_CFLAGS} -DNO_SHARED_LIBS=1
 ip6tables_static_LDADD      = libiptc/libip6tc.la extensions/libext6.a -lm
 
-bin_PROGRAMS     = iptables-xml
+bin_PROGRAMS     =
 sbin_PROGRAMS    =
 noinst_PROGRAMS  =
 man_MANS         = iptables.8 iptables-restore.8 iptables-save.8 \
@@ -98,6 +98,7 @@ sbin_PROGRAMS += ip6tables-static
 endif
 endif
 if ENABLE_SHARED
+bin_PROGRAMS  += iptables-xml
 if ENABLE_IPV4
 sbin_PROGRAMS += iptables iptables-multi iptables-restore iptables-save
 endif

Re: [PATCH] Only build iptables-xml when shared libraries are enabled

[Jan Engelhardt]

On Monday 2009-07-20 06:44, Philip Craig wrote:

>
>
>
>Only build iptables-xml when shared libraries are enabled
>
>There is no static version of iptables-xml currently.

Naah:
-rwxr-xr-x 1 jengelh users 209336 Jul 16 19:41 iptables-xml

(look at the size, it has obviously been compiled with
./configure --disable-shared)

>I'm building for a target that has no libdl.
>@@ -81,7 +81,7 @@ ip6tables_static_SOURCES    = ${ip6tables_multi_SOURCES} xtables.c
> ip6tables_static_CFLAGS     = ${ip6tables_multi_CFLAGS} -DNO_SHARED_LIBS=1
> ip6tables_static_LDADD      = libiptc/libip6tc.la extensions/libext6.a -lm
> 
>-bin_PROGRAMS     = iptables-xml
>+bin_PROGRAMS     =
> sbin_PROGRAMS    =
> noinst_PROGRAMS  =
> man_MANS         = iptables.8 iptables-restore.8 iptables-save.8 \

Since there is no mention of -ldl for `grep iptables.xml Makefile.am`
(instead we need to change something else), I declare this patch
not applicable.

Static, as far as iptables is concerned, only means that extensions
are built-in. It still uses libc and so on. Maybe should rename that
to avoid confusion..