diff for duplicates of <4A64665B.9000504@nokia.com> diff --git a/a/1.txt b/N1/1.txt index a358976..16d9e96 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,12 +19,12 @@ arun c wrote: >>> >>> - T i = E->fld; >>> + T i; ->>> ... when != Eá +>>> ... when != E=E1 >>> when != i ->>> BUG_ON (E = NULL|| +>>> BUG_ON (E == NULL|| >>> - i >>> + E->fld ->>> = NULL || ...); +>>> == NULL || ...); >>> + i = E->fld; >>> // </smpl> >>> @@ -47,8 +47,8 @@ arun c wrote: >>> + struct mmc_omap_host *host; >>> unsigned long flags; >>> int i; ->>> - BUG_ON(slot = NULL || host->mmc = NULL); ->>> + BUG_ON(slot = NULL || slot->host->mmc = NULL); +>>> - BUG_ON(slot == NULL || host->mmc == NULL); +>>> + BUG_ON(slot == NULL || slot->host->mmc == NULL); >>> + host = slot->host; >>> if (clk_enabled) >>> /* Keeps clock running for at least 8 cycles on valid freq @@ -63,13 +63,13 @@ arun c wrote: >> unsigned long flags; >> int i; >> ->>> - BUG_ON(slot = NULL || host->mmc = NULL); ->>> + BUG_ON(host->mmc = NULL); +>>> - BUG_ON(slot == NULL || host->mmc == NULL); +>>> + BUG_ON(host->mmc == NULL); >> if (clk_enabled) >> /* Keeps clock running for at least 8 cycles on valid freq */ >> -- > -> According to http://isc.sans.org/diary.html?storyidh20&rss "NULL check" +> According to http://isc.sans.org/diary.html?storyid=6820&rss "NULL check" > must be done before assigning the values. Does Julia Lawall's version > is the more correct one?? > @@ -78,8 +78,3 @@ arun c wrote: It is not a "NULL check" it is an assertion, which can be compiled out. On some platforms BUG is implemented as a null dereference anyway e.g. on ARM it is *(int *)0 = 0; - --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 12e38ec..31a93c1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0c656a4d20907200533t1cbe1476l62d8a51fdb796c70@mail.gmail.com\0" "From\0Adrian Hunter <adrian.hunter@nokia.com>\0" "Subject\0Re: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test\0" - "Date\0Mon, 20 Jul 2009 12:43:07 +0000\0" + "Date\0Mon, 20 Jul 2009 15:43:07 +0300\0" "To\0arun c <arun.edarath@gmail.com>\0" "Cc\0Julia Lawall <julia@diku.dk>" Lavinen Jarkko (Nokia-D/Helsinki) <jarkko.lavinen@nokia.com> @@ -33,12 +33,12 @@ ">>>\n" ">>> - T i = E->fld;\n" ">>> + T i;\n" - ">>> ... when != E\303\241\n" + ">>> ... when != E=E1\n" ">>> when != i\n" - ">>> BUG_ON (E = NULL||\n" + ">>> BUG_ON (E == NULL||\n" ">>> - i\n" ">>> + E->fld\n" - ">>> = NULL || ...);\n" + ">>> == NULL || ...);\n" ">>> + i = E->fld;\n" ">>> // </smpl>\n" ">>>\n" @@ -61,8 +61,8 @@ ">>> + struct mmc_omap_host *host;\n" ">>> unsigned long flags;\n" ">>> int i;\n" - ">>> - BUG_ON(slot = NULL || host->mmc = NULL);\n" - ">>> + BUG_ON(slot = NULL || slot->host->mmc = NULL);\n" + ">>> - BUG_ON(slot == NULL || host->mmc == NULL);\n" + ">>> + BUG_ON(slot == NULL || slot->host->mmc == NULL);\n" ">>> + host = slot->host;\n" ">>> if (clk_enabled)\n" ">>> /* Keeps clock running for at least 8 cycles on valid freq\n" @@ -77,13 +77,13 @@ ">> unsigned long flags;\n" ">> int i;\n" ">>\n" - ">>> - BUG_ON(slot = NULL || host->mmc = NULL);\n" - ">>> + BUG_ON(host->mmc = NULL);\n" + ">>> - BUG_ON(slot == NULL || host->mmc == NULL);\n" + ">>> + BUG_ON(host->mmc == NULL);\n" ">> if (clk_enabled)\n" ">> /* Keeps clock running for at least 8 cycles on valid freq */\n" ">> --\n" "> \n" - "> According to http://isc.sans.org/diary.html?storyidh20&rss \"NULL check\"\n" + "> According to http://isc.sans.org/diary.html?storyid=6820&rss \"NULL check\"\n" "> must be done before assigning the values. Does Julia Lawall's version\n" "> is the more correct one??\n" "> \n" @@ -91,11 +91,6 @@ "\n" "It is not a \"NULL check\" it is an assertion, which can be compiled out.\n" "On some platforms BUG is implemented as a null dereference anyway\n" - "e.g. on ARM it is *(int *)0 = 0;\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + e.g. on ARM it is *(int *)0 = 0; -f23df24ea997c8e7cd48b167a11691d1d092b728e4eb9edacfef963e0dd0415d +f60d853fbc8da8b48a58415e4daee7d914ddb13ad93b91782b130d5423e1c442
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.