All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Roth <frashman@freenet.de>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH]ctxfi: Swapped SURROUND-SIDE channels on emu20k2
Date: Mon, 20 Jul 2009 17:00:14 +0200	[thread overview]
Message-ID: <4A64867E.3060003@freenet.de> (raw)
In-Reply-To: <s5hocrf5y3z.wl%tiwai@suse.de>

My patch description:

On Soundblaster X-FI Titanium with emu20k2 the SIDE and SURROUND channels were swapped and wrong.
I double checked it with connector colors and creative soundblaster windows drivers.

So I swapped them to the true order.
Now "speaker-test -c6" and "speaker-test -c8" are working fine.

It's my first patch submit ever, so if I've done anything wrong, please correct me ;-)


Signed-off-by: Frank Roth <frashman@freenet.de>
--- alsa-driver-unstable/alsa-kernel/pci/ctxfi/ctdaio.c.orig	2009-07-20 16:20:37.273239043 +0200
+++ alsa-driver-unstable/alsa-kernel/pci/ctxfi/ctdaio.c	2009-07-20 14:26:59.798760829 +0200
@@ -57,9 +57,9 @@ struct daio_rsc_idx idx_20k1[NUM_DAIOTYP

  struct daio_rsc_idx idx_20k2[NUM_DAIOTYP] = {
  	[LINEO1] = {.left = 0x40, .right = 0x41},
-	[LINEO2] = {.left = 0x70, .right = 0x71},
+	[LINEO2] = {.left = 0x60, .right = 0x61},
  	[LINEO3] = {.left = 0x50, .right = 0x51},
-	[LINEO4] = {.left = 0x60, .right = 0x61},
+	[LINEO4] = {.left = 0x70, .right = 0x71},
  	[LINEIM] = {.left = 0x45, .right = 0xc5},
  	[SPDIFOO] = {.left = 0x00, .right = 0x01},
  	[SPDIFIO] = {.left = 0x05, .right = 0x85},

  reply	other threads:[~2009-07-20 15:00 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 10:55 Testers wanted: New SB X-Fi driver Frashman
2009-07-15 18:44 ` Ted T. Logan
2009-07-16  9:22 ` Takashi Iwai
2009-07-16 10:31   ` Frashman
2009-07-16 10:37     ` Frank
2009-07-20 12:33       ` Frank Roth
2009-07-20 12:37         ` Takashi Iwai
2009-07-20 15:00           ` Frank Roth [this message]
2009-07-20 15:10             ` [PATCH]ctxfi: Swapped SURROUND-SIDE channels on emu20k2 Takashi Iwai
2009-07-16 18:30   ` Testers wanted: New SB X-Fi driver Ted T. Logan
2009-07-16 19:20     ` John L. Utz III
2009-07-19 15:35       ` Ted T. Logan
2009-07-19 16:01         ` Takashi Iwai
2009-07-20  0:38           ` Ted T. Logan
2009-07-20  5:37             ` Takashi Iwai
2009-07-20 17:32               ` Ted T. Logan
2009-07-20 17:33               ` Ted T. Logan
2009-07-20 17:47                 ` Takashi Iwai
2009-07-21  7:23                   ` Ted T. Logan
2009-07-23 14:55                     ` Takashi Iwai
     [not found]                       ` <1248810610.3475.1.camel@localhost.localdomain>
2009-07-29  6:37                         ` Takashi Iwai
2009-08-05  9:31               ` Ted T. Logan
2009-08-05 18:17                 ` Testers wanted: New SB X-Fi driver - POC for creative? Ted T. Logan
2009-08-06  6:13                   ` Takashi Iwai
2009-08-09 19:17                     ` Ted T. Logan
2009-07-22 17:53           ` Testers wanted: New SB X-Fi driver Ted T. Logan
2009-07-22 19:33             ` Takashi Iwai
2009-07-22 19:40               ` Ted T. Logan
2009-07-23  5:30                 ` Takashi Iwai
2009-07-23 17:53                   ` Ted T. Logan
     [not found]   ` <4A5EFEA3.7060603@freenet.de>
2009-07-20 17:50     ` Takashi Iwai
2009-07-20 18:47       ` Frank Roth
2009-07-21  5:47         ` Takashi Iwai
2009-07-21 10:52   ` Frank Roth
2009-07-21 11:12     ` Takashi Iwai
2009-07-21 16:51       ` Frank Roth
2009-07-21 17:09         ` James Courtier-Dutton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A64867E.3060003@freenet.de \
    --to=frashman@freenet.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.