From: Rik van Riel <riel@redhat.com>
To: Izik Eidus <ieidus@redhat.com>
Cc: akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk,
aarcange@redhat.com, chrisw@redhat.com, avi@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
nickpiggin@yahoo.com.au, Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH 05/10] ksm: no debug in page_dup_rmap()
Date: Mon, 20 Jul 2009 14:11:14 -0400 [thread overview]
Message-ID: <4A64B342.8070002@redhat.com> (raw)
In-Reply-To: <1247851850-4298-6-git-send-email-ieidus@redhat.com>
Izik Eidus wrote:
> From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
>
> page_dup_rmap(), used on each mapped page when forking, was originally
> just an inline atomic_inc of mapcount. 2.6.22 added CONFIG_DEBUG_VM
> out-of-line checks to it, which would need to be ever-so-slightly
> complicated to allow for the PageKsm() we're about to define.
>
> But I think these checks never caught anything. And if it's coding
> errors we're worried about, such checks should be in page_remove_rmap()
> too, not just when forking; whereas if it's pagetable corruption we're
> worried about, then they shouldn't be limited to CONFIG_DEBUG_VM.
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Izik Eidus <ieidus@redhat.com>
Cc: akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk,
aarcange@redhat.com, chrisw@redhat.com, avi@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
nickpiggin@yahoo.com.au, Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH 05/10] ksm: no debug in page_dup_rmap()
Date: Mon, 20 Jul 2009 14:11:14 -0400 [thread overview]
Message-ID: <4A64B342.8070002@redhat.com> (raw)
In-Reply-To: <1247851850-4298-6-git-send-email-ieidus@redhat.com>
Izik Eidus wrote:
> From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
>
> page_dup_rmap(), used on each mapped page when forking, was originally
> just an inline atomic_inc of mapcount. 2.6.22 added CONFIG_DEBUG_VM
> out-of-line checks to it, which would need to be ever-so-slightly
> complicated to allow for the PageKsm() we're about to define.
>
> But I think these checks never caught anything. And if it's coding
> errors we're worried about, such checks should be in page_remove_rmap()
> too, not just when forking; whereas if it's pagetable corruption we're
> worried about, then they shouldn't be limited to CONFIG_DEBUG_VM.
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-20 18:11 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 17:30 [PATCH 00/10] ksm resend Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 01/10] ksm: add mmu_notifier set_pte_at_notify() Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 02/10] ksm: first tidy up madvise_vma() Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 03/10] ksm: define MADV_MERGEABLE and MADV_UNMERGEABLE Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 04/10] ksm: the mm interface to ksm Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 05/10] ksm: no debug in page_dup_rmap() Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 06/10] ksm: identify PageKsm pages Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 07/10] ksm: Kernel SamePage Merging Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 08/10] ksm: prevent mremap move poisoning Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 09/10] ksm: change copyright message Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-17 17:30 ` [PATCH 10/10] ksm: change ksm nice level to be 5 Izik Eidus
2009-07-17 17:30 ` Izik Eidus
2009-07-19 13:50 ` Hugh Dickins
2009-07-19 13:50 ` Hugh Dickins
2009-07-20 4:50 ` Balbir Singh
2009-07-20 4:50 ` Balbir Singh
2009-07-20 11:48 ` Izik Eidus
2009-07-20 11:48 ` Izik Eidus
2009-07-20 12:14 ` Balbir Singh
2009-07-20 12:14 ` Balbir Singh
2009-07-20 18:38 ` Rik van Riel
2009-07-20 18:38 ` Rik van Riel
2009-07-19 13:49 ` [PATCH 09/10] ksm: change copyright message Hugh Dickins
2009-07-19 13:49 ` Hugh Dickins
2009-07-20 18:37 ` Rik van Riel
2009-07-20 18:37 ` Rik van Riel
2009-07-20 18:37 ` [PATCH 08/10] ksm: prevent mremap move poisoning Rik van Riel
2009-07-20 18:37 ` Rik van Riel
2009-07-20 18:35 ` [PATCH 07/10] ksm: Kernel SamePage Merging Rik van Riel
2009-07-20 18:35 ` Rik van Riel
2009-07-18 2:45 ` [PATCH 06/10] ksm: identify PageKsm pages Wu Fengguang
2009-07-18 2:45 ` Wu Fengguang
2009-07-20 18:32 ` Rik van Riel
2009-07-20 18:32 ` Rik van Riel
2009-07-21 17:51 ` Andrea Arcangeli
2009-07-21 17:51 ` Andrea Arcangeli
2009-07-21 17:55 ` Rik van Riel
2009-07-21 17:55 ` Rik van Riel
2009-07-21 18:01 ` Andrea Arcangeli
2009-07-21 18:01 ` Andrea Arcangeli
2009-07-21 18:17 ` Izik Eidus
2009-07-21 18:17 ` Izik Eidus
2009-07-22 12:54 ` Hugh Dickins
2009-07-22 12:54 ` Hugh Dickins
2009-07-23 2:06 ` KAMEZAWA Hiroyuki
2009-07-23 2:06 ` KAMEZAWA Hiroyuki
2009-07-23 11:43 ` Hugh Dickins
2009-07-23 11:43 ` Hugh Dickins
2009-07-23 11:49 ` Lee Schermerhorn
2009-07-23 11:49 ` Lee Schermerhorn
2009-07-22 12:45 ` Hugh Dickins
2009-07-22 12:45 ` Hugh Dickins
2009-07-22 16:52 ` Andrea Arcangeli
2009-07-22 16:52 ` Andrea Arcangeli
2009-07-23 11:36 ` Hugh Dickins
2009-07-23 11:36 ` Hugh Dickins
2009-07-20 18:11 ` Rik van Riel [this message]
2009-07-20 18:11 ` [PATCH 05/10] ksm: no debug in page_dup_rmap() Rik van Riel
2009-07-21 7:16 ` Nick Piggin
2009-07-21 7:16 ` Nick Piggin
2009-07-20 17:38 ` [PATCH 04/10] ksm: the mm interface to ksm Rik van Riel
2009-07-20 17:38 ` Rik van Riel
2009-07-20 15:09 ` [PATCH 03/10] ksm: define MADV_MERGEABLE and MADV_UNMERGEABLE Rik van Riel
2009-07-20 15:09 ` Rik van Riel
2009-07-20 15:44 ` Ralf Baechle
2009-07-20 15:44 ` Ralf Baechle
2009-07-20 15:05 ` [PATCH 02/10] ksm: first tidy up madvise_vma() Rik van Riel
2009-07-20 15:05 ` Rik van Riel
2009-07-20 14:48 ` [PATCH 01/10] ksm: add mmu_notifier set_pte_at_notify() Rik van Riel
2009-07-20 14:48 ` Rik van Riel
2009-07-21 17:59 ` [PATCH 00/10] ksm resend Andrea Arcangeli
2009-07-21 17:59 ` Andrea Arcangeli
2009-07-22 13:05 ` Hugh Dickins
2009-07-22 13:05 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A64B342.8070002@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.