[RFC] hal-0.5.12 requires blkid >= 1.43

[RFC] hal-0.5.12 requires blkid >= 1.43

[Ulf Samuelsson]

[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]

hal does not build when bitbaking gpe-image,since
blkid is 1.41.8 and hal requires >= 1.43.
1.41.8 seems to be the latest!
The attached patch fixes configure and configure.in in the hal

First the patch to the recipe.

diff --git a/recipes/hal/hal_0.5.12.bb b/recipes/hal/hal_0.5.12.bb
index b6531e8..155c2e3 100644
--- a/recipes/hal/hal_0.5.12.bb
+++ b/recipes/hal/hal_0.5.12.bb
@@ -2,6 +2,10 @@ require hal.inc
 
 DEFAULT_PREFERENCE = "-1"
 
+PR = "r1"
+
+SRC_URI += " file://hal-0.5.12-blkid-1.41.patch;patch=1"
+
 # The following code finds the right linux/input.h,
 # which also works with external-toolchain/SDK
 do_configure() {


---
Then the patch which should reside in the
"recipe/hal/hal-0.5.12/hal-0.5.12-blkid-1.41.patch"


diff -urN a/configure b/configure
--- a/configure    2009-07-21 10:02:37.000000000 +0200
+++ b/configure    2009-07-21 10:06:27.000000000 +0200
@@ -2791,7 +2791,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage
diff -urN a/configure.in b/configure.in
--- a/configure.in    2009-05-10 21:43:52.000000000 +0200
+++ b/configure.in    2009-07-21 10:06:51.000000000 +0200
@@ -13,7 +13,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage


Comments?

Best Regards
Ulf Samuelsson


[-- Attachment #2: hal-0.5.12-blkid-1.41.patch --]
[-- Type: text/x-patch, Size: 884 bytes --]

diff -urN a/configure b/configure
--- a/configure	2009-07-21 10:02:37.000000000 +0200
+++ b/configure	2009-07-21 10:06:27.000000000 +0200
@@ -2791,7 +2791,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage
diff -urN a/configure.in b/configure.in
--- a/configure.in	2009-05-10 21:43:52.000000000 +0200
+++ b/configure.in	2009-07-21 10:06:51.000000000 +0200
@@ -13,7 +13,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Koen Kooi]

On 21-07-09 10:33, Ulf Samuelsson wrote:

> diff -urN a/configure b/configure
> --- a/configure    2009-07-21 10:02:37.000000000 +0200
> +++ b/configure    2009-07-21 10:06:27.000000000 +0200
> @@ -2791,7 +2791,7 @@
>
>   glib_module="glib-2.0>= 2.10.0 gobject-2.0>  2.10.0 dbus-glib-1>= 0.61"
>   dbus_module="dbus-1>= 0.61"
> -blkid_module="blkid>= 1.43"
> +blkid_module="blkid>= 1.41"
>   polkit_module="polkit>= 0.5"
>
>   # libtool versioning - this applies to libhal and libhal-storage
> diff -urN a/configure.in b/configure.in
> --- a/configure.in    2009-05-10 21:43:52.000000000 +0200
> +++ b/configure.in    2009-07-21 10:06:51.000000000 +0200
> @@ -13,7 +13,7 @@
>
>   glib_module="glib-2.0>= 2.10.0 gobject-2.0>  2.10.0 dbus-glib-1>= 0.61"
>   dbus_module="dbus-1>= 0.61"
> -blkid_module="blkid>= 1.43"
> +blkid_module="blkid>= 1.41"
>   polkit_module="polkit>= 0.5"
>
>   # libtool versioning - this applies to libhal and libhal-storage
>
>
> Comments?

configure gets generated from configure.in, so you only have to patch 
one file. And please use git-format-patch to make a single patch next time.

Anyway, I solved it in a different way.

regards,

Koen

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Florian Boor]

Hi,

Ulf Samuelsson schrieb:

> Comments?

even if it looks strange... I agree. Very unlikely that the hal maintainers
meant to depend on a future release of e2fsprogs.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Koen Kooi]

On 21-07-09 12:38, Florian Boor wrote:
> Hi,
>
> Ulf Samuelsson schrieb:
>
>> Comments?
>
> even if it looks strange... I agree. Very unlikely that the hal maintainers
> meant to depend on a future release of e2fsprogs.

The util-linux-ng people made it go backwards when moving it from 
e2fsprogs to util-linux-ng. Upstream error, but relatively harmless as 
the resuling package gets 2.16 as PV.

regards,

Koen

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Koen Kooi]

On 21-07-09 13:46, Koen Kooi wrote:
> On 21-07-09 12:38, Florian Boor wrote:
>> Hi,
>>
>> Ulf Samuelsson schrieb:
>>
>>> Comments?
>>
>> even if it looks strange... I agree. Very unlikely that the hal
>> maintainers
>> meant to depend on a future release of e2fsprogs.
>
> The util-linux-ng people made it go backwards when moving it from
> e2fsprogs to util-linux-ng. Upstream error, but relatively harmless as
> the resuling package gets 2.16 as PV.

I am confused, ignore me

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Phil Blundell]

On Tue, 2009-07-21 at 10:33 +0200, Ulf Samuelsson wrote:
> hal does not build when bitbaking gpe-image,since
> blkid is 1.41.8 and hal requires >= 1.43.
> 1.41.8 seems to be the latest!
> The attached patch fixes configure and configure.in in the hal

I think the idea is that you're meant to use libblkid from
util-linux-ng.  I've no idea what the difference is, though: it's
possible that 1.41.8 would indeed work correctly.  I guess you'd have to
ask the hal h4x0rs why they selected 1.43 as the minimum version to be
sure.

p.

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Ulf Samuelsson]

   Phil Blundell skrev:

On Tue, 2009-07-21 at 10:33 +0200, Ulf Samuelsson wrote:


hal does not build when bitbaking gpe-image,since
blkid is 1.41.8 and hal requires >= 1.43.
1.41.8 seems to be the latest!
The attached patch fixes configure and configure.in in the hal


I think the idea is that you're meant to use libblkid from
util-linux-ng.  I've no idea what the difference is, though: it's
possible that 1.41.8 would indeed work correctly.  I guess you'd have to
ask the hal h4x0rs why they selected 1.43 as the minimum version to be
sure.

p.



I did not do anything special, just "bitbake gpe-image".

Looks like "gpe-image" should be updated to use "util-linux-ng"
instead of my proposed patch.

--
Best Regards
Ulf Samuelsson

Re: [RFC] hal-0.5.12 requires blkid >= 1.43

[Phil Blundell]

On Tue, 2009-07-21 at 18:39 +0200, Ulf Samuelsson wrote:
> Looks like "gpe-image" should be updated to use "util-linux-ng"
> instead of my proposed patch.

I don't think this is a gpe-image issue as such; it sounds more like a
case of wrong dependencies on the hal package.

p.