[Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type

[Anthony Liguori <aliguori@us.ibm.com>]

Gerd Hoffmann wrote:
> On 07/21/09 16:53, Anthony Liguori wrote:
>> Gerd Hoffmann wrote:
>>> On 07/17/09 16:41, Anthony Liguori wrote:
>>>
>>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>>
>>> Hmm, I think that goes into the wrong direction. Properties should not
>>> be pointers to internal qemu state. Yes, there is qemu_prop_ptr, but I
>>> consider that a temporary stopgap until we can do better.
>>> Instead CharDriverState's should get a name and we need a way to
>>> lookup them by name. Then we can store the name instead of a pointer
>>> into the property.
>>
>> Would you have a property type that was basically a char driver state 
>> name?
>
> Yes.  Same for drives and others.  A generic string property should do 
> I think.

Couldn't a struct pointer be used for that though?  It can still be 
exposed as a string to the user.

> cheers,
>   Gerd
>


-- 
Regards,

Anthony Liguori