From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type
Date: Tue, 21 Jul 2009 17:34:54 +0200 [thread overview]
Message-ID: <4A65E01E.8010505@redhat.com> (raw)
In-Reply-To: <4A65DD7C.3090902@us.ibm.com>
On 07/21/09 17:23, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>>> Would you have a property type that was basically a char driver state
>>> name?
>>
>> Yes. Same for drives and others. A generic string property should do I
>> think.
>
> Couldn't a struct pointer be used for that though? It can still be
> exposed as a string to the user.
Hmm, didn't think about that possibility. Somehow makes sense as it
would move the lookup-by-name into generic code (i.e.
qemu_prop_chardev->parse).
Not sure what qdev_prop_set_chrdev() should accept then. struct
pointer? string?
cheers,
Gerd
next prev parent reply other threads:[~2009-07-21 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 14:41 [Qemu-devel] [PATCH 0/2][RFC] Introduce macros for setting properties Anthony Liguori
2009-07-17 14:41 ` [Qemu-devel] [PATCH 1/2] Introduce CharDriverState qdev property type Anthony Liguori
2009-07-21 14:46 ` [Qemu-devel] " Gerd Hoffmann
2009-07-21 14:53 ` Anthony Liguori
2009-07-21 15:03 ` Gerd Hoffmann
2009-07-21 15:14 ` Gerd Hoffmann
2009-07-21 15:23 ` Anthony Liguori
2009-07-21 15:34 ` Gerd Hoffmann [this message]
2009-07-21 15:47 ` Anthony Liguori
2009-07-22 9:48 ` Gerd Hoffmann
2009-07-17 14:41 ` [Qemu-devel] [PATCH 2/2] Introduce macro for defining qdev properties Anthony Liguori
2009-07-17 17:23 ` Blue Swirl
2009-07-17 17:26 ` Anthony Liguori
2009-07-17 17:33 ` Paul Brook
2009-07-17 18:11 ` Anthony Liguori
2009-07-17 18:32 ` Blue Swirl
2009-07-17 20:05 ` Anthony Liguori
2009-07-17 22:58 ` Paul Brook
2009-07-18 12:43 ` Jamie Lokier
2009-07-18 16:13 ` Anthony Liguori
2009-07-20 2:29 ` Jamie Lokier
2009-07-21 8:30 ` [Qemu-devel] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A65E01E.8010505@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.