* [PATCH 1/2] Add genhd flag requesting notification of partition changes only.
@ 2009-07-22 8:01 Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2009-07-22 8:01 UTC (permalink / raw)
To: Alasdair Kergon; +Cc: dm-devel, jens.axboe
This patch provides notification mechanism which allows handle partition
code in userspace.
If the BLKRRPART ioctl arrives and GENHD_FL_USERSPACE_PARTITIONS
is set, just send uevent and ignore in-kernel partitioning code.
This is useful e.g. for device-mapper devices, which can use kpartx
or similar tool in udev rules.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
block/ioctl.c | 3 ++-
drivers/md/dm.c | 1 +
fs/partitions/check.c | 7 +++++++
include/linux/genhd.h | 8 ++++++++
4 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/block/ioctl.c b/block/ioctl.c
index 500e4c7..bce793f 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -101,7 +101,8 @@ static int blkdev_reread_part(struct block_device *bdev)
struct gendisk *disk = bdev->bd_disk;
int res;
- if (!disk_partitionable(disk) || bdev != bdev->bd_contains)
+ if (!disk_userspace_partitions(disk) &&
+ (!disk_partitionable(disk) || bdev != bdev->bd_contains))
return -EINVAL;
if (!capable(CAP_SYS_ADMIN))
return -EACCES;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 3c6d4ee..df3332d 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1791,6 +1791,7 @@ static struct mapped_device *alloc_dev(int minor)
md->disk->queue = md->queue;
md->disk->private_data = md;
sprintf(md->disk->disk_name, "dm-%d", minor);
+ md->disk->flags |= GENHD_FL_USERSPACE_PARTITIONS;
add_disk(md->disk);
format_dev_t(md->name, MKDEV(_major, minor));
diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index 1a9c787..01f97dd 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -536,6 +536,13 @@ int rescan_partitions(struct gendisk *disk, struct block_device *bdev)
disk->fops->revalidate_disk(disk);
check_disk_size_change(disk, bdev);
bdev->bd_invalidated = 0;
+
+ /* partitions handled in userspace, just send change event */
+ if (disk_userspace_partitions(disk)) {
+ kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE);
+ return 0;
+ }
+
if (!get_capacity(disk) || !(state = check_partition(disk, bdev)))
return 0;
if (IS_ERR(state)) /* I/O error reading the partition table */
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index 45fc320..a5ee079 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -116,6 +116,9 @@ struct hd_struct {
#define GENHD_FL_EXT_DEVT 64 /* allow extended devt */
#define GENHD_FL_NATIVE_CAPACITY 128
+/* notify udev instead of use in-kernel partitioning */
+#define GENHD_FL_USERSPACE_PARTITIONS 256
+
#define BLK_SCSI_MAX_CMDS (256)
#define BLK_SCSI_CMD_PER_LONG (BLK_SCSI_MAX_CMDS / (sizeof(long) * 8))
@@ -180,6 +183,11 @@ static inline struct gendisk *part_to_disk(struct hd_struct *part)
return NULL;
}
+static inline bool disk_userspace_partitions(struct gendisk *disk)
+{
+ return (disk->flags & GENHD_FL_USERSPACE_PARTITIONS) ? 1 : 0;
+}
+
static inline int disk_max_parts(struct gendisk *disk)
{
if (disk->flags & GENHD_FL_EXT_DEVT)
--
1.5.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 1/2] Add genhd flag requesting notification of partition changes only.
@ 2009-07-22 10:17 Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2009-07-22 10:17 UTC (permalink / raw)
To: Alasdair G Kergon; +Cc: device-mapper development, Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
Resend patch 1/2; seems to be stuck in the mailqueue somewhere.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
[-- Attachment #2: Add-genhd-flag-requesting-notification-of-partition.patch --]
[-- Type: text/x-patch, Size: 3279 bytes --]
From 1aeec7a3141af62456576baf16978738c7bf4152 Mon Sep 17 00:00:00 2001
From: Hannes Reinecke <hare@suse.de>
Date: Wed, 22 Jul 2009 08:18:18 +0200
Subject: [PATCH 1/2] Add genhd flag requesting notification of partition changes only.
This patch provides notification mechanism which allows handle partition
code in userspace.
If the BLKRRPART ioctl arrives and GENHD_FL_USERSPACE_PARTITIONS
is set, just send uevent and ignore in-kernel partitioning code.
This is useful e.g. for device-mapper devices, which can use kpartx
or similar tool in udev rules.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
block/ioctl.c | 3 ++-
drivers/md/dm.c | 1 +
fs/partitions/check.c | 7 +++++++
include/linux/genhd.h | 8 ++++++++
4 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/block/ioctl.c b/block/ioctl.c
index 500e4c7..bce793f 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -101,7 +101,8 @@ static int blkdev_reread_part(struct block_device *bdev)
struct gendisk *disk = bdev->bd_disk;
int res;
- if (!disk_partitionable(disk) || bdev != bdev->bd_contains)
+ if (!disk_userspace_partitions(disk) &&
+ (!disk_partitionable(disk) || bdev != bdev->bd_contains))
return -EINVAL;
if (!capable(CAP_SYS_ADMIN))
return -EACCES;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 3c6d4ee..df3332d 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1791,6 +1791,7 @@ static struct mapped_device *alloc_dev(int minor)
md->disk->queue = md->queue;
md->disk->private_data = md;
sprintf(md->disk->disk_name, "dm-%d", minor);
+ md->disk->flags |= GENHD_FL_USERSPACE_PARTITIONS;
add_disk(md->disk);
format_dev_t(md->name, MKDEV(_major, minor));
diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index 1a9c787..01f97dd 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -536,6 +536,13 @@ int rescan_partitions(struct gendisk *disk, struct block_device *bdev)
disk->fops->revalidate_disk(disk);
check_disk_size_change(disk, bdev);
bdev->bd_invalidated = 0;
+
+ /* partitions handled in userspace, just send change event */
+ if (disk_userspace_partitions(disk)) {
+ kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE);
+ return 0;
+ }
+
if (!get_capacity(disk) || !(state = check_partition(disk, bdev)))
return 0;
if (IS_ERR(state)) /* I/O error reading the partition table */
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index 45fc320..a5ee079 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -116,6 +116,9 @@ struct hd_struct {
#define GENHD_FL_EXT_DEVT 64 /* allow extended devt */
#define GENHD_FL_NATIVE_CAPACITY 128
+/* notify udev instead of use in-kernel partitioning */
+#define GENHD_FL_USERSPACE_PARTITIONS 256
+
#define BLK_SCSI_MAX_CMDS (256)
#define BLK_SCSI_CMD_PER_LONG (BLK_SCSI_MAX_CMDS / (sizeof(long) * 8))
@@ -180,6 +183,11 @@ static inline struct gendisk *part_to_disk(struct hd_struct *part)
return NULL;
}
+static inline bool disk_userspace_partitions(struct gendisk *disk)
+{
+ return (disk->flags & GENHD_FL_USERSPACE_PARTITIONS) ? 1 : 0;
+}
+
static inline int disk_max_parts(struct gendisk *disk)
{
if (disk->flags & GENHD_FL_EXT_DEVT)
--
1.5.3.2
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-22 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-22 10:17 [PATCH 1/2] Add genhd flag requesting notification of partition changes only Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2009-07-22 8:01 Hannes Reinecke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.