From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG
Date: Wed, 22 Jul 2009 14:42:16 -0500 [thread overview]
Message-ID: <4A676B98.1060104@us.ibm.com> (raw)
In-Reply-To: <4A676B27.10100@web.de>
Jan Kiszka wrote:
>> That makes me uncomfortable. Shouldn't we make kvm return something
>> that's exposed to userspace?
>>
>>
>
> Yes, but we can't do this from user space :) (or in other words: there
> are already kernels out there which return this invalid code).
>
But since it's not symbolic, at some point in time the meaning of 524
can potentially change and introduce a very, very subtle bug.
> The situation would only be different if Alex said that it takes further
> kernel patches anyway to make his PowerPC targets work. Dunno.
>
Certainly, his PPC target is not in any released kernel version so
there's time to fix things properly.
> Jan
>
>
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-22 19:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com>
2009-07-22 17:00 ` [Qemu-devel] Re: [COMMIT bd83677] Fake dirty loggin when it's not there Jan Kiszka
2009-07-22 18:15 ` Anthony Liguori
2009-07-22 19:27 ` [Qemu-devel] [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG Jan Kiszka
2009-07-22 19:29 ` [Qemu-devel] " Anthony Liguori
2009-07-22 19:40 ` Jan Kiszka
2009-07-22 19:42 ` Anthony Liguori [this message]
2009-07-22 20:07 ` Jan Kiszka
2009-07-22 21:01 ` Alexander Graf
2009-07-22 21:14 ` Jan Kiszka
2009-07-22 21:17 ` Alexander Graf
2009-07-22 21:15 ` Anthony Liguori
2009-07-22 21:24 ` Alexander Graf
2009-07-22 21:25 ` Anthony Liguori
2009-07-22 21:36 ` Alexander Graf
2009-07-22 21:38 ` Anthony Liguori
2009-07-22 21:30 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A676B98.1060104@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=agraf@suse.de \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.