All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG
Date: Wed, 22 Jul 2009 23:30:08 +0200	[thread overview]
Message-ID: <4A6784E0.2070701@web.de> (raw)
In-Reply-To: <137B26C8-A9A7-4253-8977-C43C3CEFD30C@suse.de>

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Alexander Graf wrote:
> 
> Am 22.07.2009 um 23:15 schrieb Anthony Liguori <aliguori@us.ibm.com>:
> 
>> Alexander Graf wrote:
>>>
>>> The only thing I'd agree with as a good idea instead of the version I
>>> sent is an explicit switch statement with an include of errno.h with
>>> __KERNEL__ set.
>>
>> No way :-)
>>
>> What's the problem with fixing the kernel to return a proper errno?
> 
> I'd rather do a proper dirty log implementation than that :). But yes,
> you convinced me. I'll just do dirtylogging for ppc.

Puh... :)

> 
> Now what about ia64?

There is a non-empty kvm_vm_ioctl_get_dirty_log() in kvm-ia64.c.

So I think we can revert your patch and just merge the tiny error-check
fix, right?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

      parent reply	other threads:[~2009-07-22 21:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200907221626.n6MGQGH0022104@d03av02.boulder.ibm.com>
2009-07-22 17:00 ` [Qemu-devel] Re: [COMMIT bd83677] Fake dirty loggin when it's not there Jan Kiszka
2009-07-22 18:15   ` Anthony Liguori
2009-07-22 19:27     ` [Qemu-devel] [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG Jan Kiszka
2009-07-22 19:29       ` [Qemu-devel] " Anthony Liguori
2009-07-22 19:40         ` Jan Kiszka
2009-07-22 19:42           ` Anthony Liguori
2009-07-22 20:07             ` Jan Kiszka
2009-07-22 21:01               ` Alexander Graf
2009-07-22 21:14                 ` Jan Kiszka
2009-07-22 21:17                   ` Alexander Graf
2009-07-22 21:15                 ` Anthony Liguori
2009-07-22 21:24                   ` Alexander Graf
2009-07-22 21:25                     ` Anthony Liguori
2009-07-22 21:36                       ` Alexander Graf
2009-07-22 21:38                         ` Anthony Liguori
2009-07-22 21:30                     ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6784E0.2070701@web.de \
    --to=jan.kiszka@web.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.