From: Jeff Garzik <jgarzik@pobox.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-ide <linux-ide@vger.kernel.org>, tj@kernel.org
Subject: Re: [RFC] add DMA setup FIS auto-activate feature
Date: Wed, 22 Jul 2009 23:59:11 -0400 [thread overview]
Message-ID: <4A67E00F.40808@pobox.com> (raw)
In-Reply-To: <1248320734.9035.22.camel@sli10-desk.sh.intel.com>
Shaohua Li wrote:
> hi,
> The SATA spec defines DMA setup FIS auto-activate optimization for FPDMA
> transfers. I had an attempt to add it, though my test doesn't show obvious
> performance improvement (not worse too), I wonder why not add this feature?
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
I agree, we should turn it on -- but doesn't this also have a controller
dependency?
IIRC, not all NCQ-capable controllers support this feature... SATA 1.0
hardware may not behave properly in response, no?
Jeff
next prev parent reply other threads:[~2009-07-23 3:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 3:45 [RFC] add DMA setup FIS auto-activate feature Shaohua Li
2009-07-23 3:50 ` Tejun Heo
2009-07-23 3:59 ` Jeff Garzik [this message]
2009-07-23 5:40 ` Shaohua Li
2009-07-23 5:45 ` Tejun Heo
2009-07-23 6:07 ` Jeff Garzik
2009-07-23 6:12 ` Tejun Heo
2009-07-23 6:48 ` Jeff Garzik
2009-07-23 7:25 ` Shaohua Li
2009-07-23 18:07 ` Robert Hancock
2009-07-23 18:11 ` Jeff Garzik
2009-07-23 20:52 ` Tejun Heo
2009-07-24 9:12 ` Shaohua Li
2009-07-25 0:47 ` Tejun Heo
2009-07-27 1:24 ` Shaohua Li
2009-07-27 1:31 ` Tejun Heo
2009-07-29 1:20 ` Jeff Garzik
2009-07-23 6:18 ` Robert Hancock
2009-07-23 9:55 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A67E00F.40808@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.