All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	Robert Hancock <hancockrwd@gmail.com>,
	linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [RFC] add DMA setup FIS auto-activate feature
Date: Sat, 25 Jul 2009 09:47:32 +0900	[thread overview]
Message-ID: <4A6A5624.7080005@kernel.org> (raw)
In-Reply-To: <20090724091215.GA27802@sli10-desk.sh.intel.com>

Hello, Shaohua.

Shaohua Li wrote:
> +	if (!(dev->horkage & ATA_HORKAGE_FPDMA_AA) &&
> +		(ap->flags & ATA_FLAG_FPDMA_AA) &&
> +		ata_id_has_fpdma_aa(dev->id)) {
> +		err_mask = ata_dev_set_feature(dev, SETFEATURES_SATA_ENABLE,
> +			SATA_FPDMA_AA);
> +		if (err_mask) {
> +			ata_dev_printk(dev, KERN_ERR, "failed to enable AA"
> +				"(error_mask=0x%x)\n", err_mask);
> +			if (err_mask != AC_ERR_DEV)
> +				dev->horkage |= ATA_HORKAGE_FPDMA_AA;
> +			return -EIO;

You can continue if err_mask equals AC_ERR_DEV.  Also, the horkage
should probably named like ATA_HORKAGE_BROKEN_FPDMA_AA.

Thanks.

-- 
tejun

  reply	other threads:[~2009-07-25  0:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23  3:45 [RFC] add DMA setup FIS auto-activate feature Shaohua Li
2009-07-23  3:50 ` Tejun Heo
2009-07-23  3:59 ` Jeff Garzik
2009-07-23  5:40   ` Shaohua Li
2009-07-23  5:45     ` Tejun Heo
2009-07-23  6:07       ` Jeff Garzik
2009-07-23  6:12         ` Tejun Heo
2009-07-23  6:48           ` Jeff Garzik
2009-07-23  7:25             ` Shaohua Li
2009-07-23 18:07               ` Robert Hancock
2009-07-23 18:11                 ` Jeff Garzik
2009-07-23 20:52                   ` Tejun Heo
2009-07-24  9:12                     ` Shaohua Li
2009-07-25  0:47                       ` Tejun Heo [this message]
2009-07-27  1:24                         ` Shaohua Li
2009-07-27  1:31                           ` Tejun Heo
2009-07-29  1:20                           ` Jeff Garzik
2009-07-23  6:18       ` Robert Hancock
2009-07-23  9:55 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6A5624.7080005@kernel.org \
    --to=tj@kernel.org \
    --cc=hancockrwd@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.