From: Anthony Liguori <aliguori@us.ibm.com>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro
Date: Mon, 27 Jul 2009 18:02:07 -0500 [thread overview]
Message-ID: <4A6E31EF.6050504@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907280101390.3551@linmac.oyster.ru>
malc wrote:
> On Mon, 27 Jul 2009, Juan Quintela wrote:
>
> This patch is pointless.
>
The INIT_FIELD() stuff is goofy. struct initializers are C99 so using
them conditionally on GNUC is incorrect. Also, if you can't rely on the
initializier, what's the point of even doing it at all since you cannot
change order.
Removing INIT_FIELD() is a big improvement IMHO.
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-27 23:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 20:23 [Qemu-devel] [PATCH 0/4] Use C99 struct initializers in audio/* Juan Quintela
2009-07-27 20:23 ` [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro Juan Quintela
2009-07-27 21:03 ` malc
2009-07-27 21:07 ` Anthony Liguori
2009-07-27 22:57 ` [Qemu-devel] " Paolo Bonzini
2009-07-27 23:02 ` Anthony Liguori [this message]
2009-07-28 16:54 ` [Qemu-devel] " malc
2009-07-28 17:13 ` [Qemu-devel] " Juan Quintela
2009-07-28 17:23 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 2/4] use C99 initializers for audio_pcm_ops Juan Quintela
2009-07-27 21:07 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 3/4] Use C99 initializers for audio_option Juan Quintela
2009-07-27 21:10 ` malc
2009-07-27 22:20 ` [Qemu-devel] " Juan Quintela
2009-07-28 8:03 ` Gerd Hoffmann
2009-07-28 8:22 ` Juan Quintela
2009-07-28 16:48 ` malc
2009-07-28 17:23 ` Juan Quintela
2009-07-28 17:39 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 4/4] use C99 initializers for all audio/* Juan Quintela
2009-07-27 21:11 ` malc
2009-07-27 20:30 ` [Qemu-devel] Re: [PATCH 0/4] Use C99 struct initializers in audio/* Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2009-07-28 8:56 [Qemu-devel] [PATCH v2 " Juan Quintela
2009-07-28 8:56 ` [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro Juan Quintela
2009-08-11 0:31 [Qemu-devel] [PATCH v3 0/4] Use C99 struct initializers in audio/* Juan Quintela
2009-08-11 0:31 ` [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6E31EF.6050504@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.