From: Juan Quintela <quintela@redhat.com>
To: malc <av1474@comtv.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro
Date: Tue, 28 Jul 2009 19:13:00 +0200 [thread overview]
Message-ID: <m3fxcgbujn.fsf@neno.mitica> (raw)
In-Reply-To: <Pine.LNX.4.64.0907282050500.2157@linmac.oyster.ru> (malc's message of "Tue\, 28 Jul 2009 20\:54\:09 +0400 \(MSD\)")
malc <av1474@comtv.ru> wrote:
> On Mon, 27 Jul 2009, Anthony Liguori wrote:
>
>> malc wrote:
>> > On Mon, 27 Jul 2009, Juan Quintela wrote:
>> >
>> > This patch is pointless.
>> >
>>
>> The INIT_FIELD() stuff is goofy. struct initializers are C99 so using
>> them conditionally on GNUC is incorrect. Also, if you can't rely on the
>> initializier, what's the point of even doing it at all since you cannot
>> change order.
>
> The reason for this goofyness is that the code was fed as is to MSVC
> (in VirtualBox), the patch looks like a change for the sake of a change.
MSVC don't support C99 initializers in 2009? Wow :)
I was trying to get everything else consistent.
Later, Juan.
next prev parent reply other threads:[~2009-07-28 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 20:23 [Qemu-devel] [PATCH 0/4] Use C99 struct initializers in audio/* Juan Quintela
2009-07-27 20:23 ` [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro Juan Quintela
2009-07-27 21:03 ` malc
2009-07-27 21:07 ` Anthony Liguori
2009-07-27 22:57 ` [Qemu-devel] " Paolo Bonzini
2009-07-27 23:02 ` [Qemu-devel] " Anthony Liguori
2009-07-28 16:54 ` malc
2009-07-28 17:13 ` Juan Quintela [this message]
2009-07-28 17:23 ` [Qemu-devel] " malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 2/4] use C99 initializers for audio_pcm_ops Juan Quintela
2009-07-27 21:07 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 3/4] Use C99 initializers for audio_option Juan Quintela
2009-07-27 21:10 ` malc
2009-07-27 22:20 ` [Qemu-devel] " Juan Quintela
2009-07-28 8:03 ` Gerd Hoffmann
2009-07-28 8:22 ` Juan Quintela
2009-07-28 16:48 ` malc
2009-07-28 17:23 ` Juan Quintela
2009-07-28 17:39 ` malc
2009-07-27 20:23 ` [Qemu-devel] [PATCH 4/4] use C99 initializers for all audio/* Juan Quintela
2009-07-27 21:11 ` malc
2009-07-27 20:30 ` [Qemu-devel] Re: [PATCH 0/4] Use C99 struct initializers in audio/* Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fxcgbujn.fsf@neno.mitica \
--to=quintela@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.