From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: qemu_cond_wait polling
Date: Tue, 28 Jul 2009 12:18:34 +0300 [thread overview]
Message-ID: <4A6EC26A.4070306@redhat.com> (raw)
In-Reply-To: <4A6EA5B3.6090500@web.de>
On 07/28/2009 10:16 AM, Jan Kiszka wrote:
> Hi,
>
> why do we wait on condition variables with silly timeouts (both in
> upstream as in qemu-kvm)? There used to be some qemu_aio_poll in
> qemu-kvm, but it's no longer there, and upstream never had (unless I
> missed something). Is this polling legacy now? Remove it?
>
>
Given that all uses are inside while loops, the timeouts are ignored.
It's completely pointless now.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: qemu_cond_wait polling
Date: Tue, 28 Jul 2009 12:18:34 +0300 [thread overview]
Message-ID: <4A6EC26A.4070306@redhat.com> (raw)
In-Reply-To: <4A6EA5B3.6090500@web.de>
On 07/28/2009 10:16 AM, Jan Kiszka wrote:
> Hi,
>
> why do we wait on condition variables with silly timeouts (both in
> upstream as in qemu-kvm)? There used to be some qemu_aio_poll in
> qemu-kvm, but it's no longer there, and upstream never had (unless I
> missed something). Is this polling legacy now? Remove it?
>
>
Given that all uses are inside while loops, the timeouts are ignored.
It's completely pointless now.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-07-28 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 7:16 qemu_cond_wait polling Jan Kiszka
2009-07-28 7:16 ` [Qemu-devel] " Jan Kiszka
2009-07-28 9:18 ` Avi Kivity [this message]
2009-07-28 9:18 ` [Qemu-devel] " Avi Kivity
2009-07-28 9:32 ` [PATCH] qemu-kvm: Drop polling property from qemu_cond_wait Jan Kiszka
2009-08-03 11:59 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6EC26A.4070306@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.