[PATCH] sctp: remove unused union (sctp_cmsg_data_t) definition .

[PATCH] sctp: remove unused union (sctp_cmsg_data_t) definition .

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Hi,
This patch removes an unused union definition (sctp_cmsg_data_t)
from include/net/sctp/user.h.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <rosenrami@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 449 bytes --]

diff --git a/include/net/sctp/user.h b/include/net/sctp/user.h
index 1580c04..be2334a 100644
--- a/include/net/sctp/user.h
+++ b/include/net/sctp/user.h
@@ -210,12 +210,6 @@ enum sctp_sinfo_flags {
 };
 
 
-typedef union {
-	__u8   			raw;
-	struct sctp_initmsg	init;
-	struct sctp_sndrcvinfo	sndrcv;
-} sctp_cmsg_data_t;
-
 /* These are cmsg_types.  */
 typedef enum sctp_cmsg_type {
 	SCTP_INIT,              /* 5.2.1 SCTP Initiation Structure */

Re: [PATCH] sctp: remove unused union (sctp_cmsg_data_t) definition

[Wei Yongjun]

Rami Rosen wrote:
> Hi,
> This patch removes an unused union definition (sctp_cmsg_data_t)
> from include/net/sctp/user.h.
>
> Regards,
> Rami Rosen
>
>
> Signed-off-by: Rami Rosen <rosenrami@gmail.com>
>   

sctp_cmsg_data_t  is not used by kernel source code, but it still used
by lksctp-tools.

Re: [PATCH] sctp: remove unused union (sctp_cmsg_data_t) definition .

[Rami Rosen]

>it still used by lksctp-tools.
I know; wouldn't it be more suitable to put it in include/linux/sctp.h ?

Regards,
Rami Rosen


On Thu, Jul 30, 2009 at 9:55 AM, Wei Yongjun<yjwei@cn.fujitsu.com> wrote:
> Rami Rosen wrote:
>> Hi,
>> This patch removes an unused union definition (sctp_cmsg_data_t)
>> from include/net/sctp/user.h.
>>
>> Regards,
>> Rami Rosen
>>
>>
>> Signed-off-by: Rami Rosen <rosenrami@gmail.com>
>>
>
> sctp_cmsg_data_t  is not used by kernel source code, but it still used
> by lksctp-tools.
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] sctp: remove unused union (sctp_cmsg_data_t) definition

[Wei Yongjun]

Rami Rosen wrote:
>> it still used by lksctp-tools.
>>     
> I know; wouldn't it be more suitable to put it in include/linux/sctp.h ?
>   

include/linux/sctp.h is used by kernel source code only.

> Regards,
> Rami Rosen
>
>
> On Thu, Jul 30, 2009 at 9:55 AM, Wei Yongjun<yjwei@cn.fujitsu.com> wrote:
>   
>> Rami Rosen wrote:
>>     
>>> Hi,
>>> This patch removes an unused union definition (sctp_cmsg_data_t)
>>> from include/net/sctp/user.h.
>>>
>>> Regards,
>>> Rami Rosen
>>>
>>>
>>> Signed-off-by: Rami Rosen <rosenrami@gmail.com>
>>>
>>>       
>> sctp_cmsg_data_t  is not used by kernel source code, but it still used
>> by lksctp-tools.
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>     
>
>
>
>   

Re: [PATCH] sctp: remove unused union (sctp_cmsg_data_t) definition

[Vlad Yasevich]

Wei Yongjun wrote:
> Rami Rosen wrote:
>>> it still used by lksctp-tools.
>>>     
>> I know; wouldn't it be more suitable to put it in include/linux/sctp.h ?
>>   
> 
> include/linux/sctp.h is used by kernel source code only.

/usr/include/netinet/sctp.h is the proper place for that definition.  If
it's not used by the kernel, it has no business living in the kernel tree.

-vlad


> 
>> Regards,
>> Rami Rosen
>>
>>
>> On Thu, Jul 30, 2009 at 9:55 AM, Wei Yongjun<yjwei@cn.fujitsu.com> wrote:
>>   
>>> Rami Rosen wrote:
>>>     
>>>> Hi,
>>>> This patch removes an unused union definition (sctp_cmsg_data_t)
>>>> from include/net/sctp/user.h.
>>>>
>>>> Regards,
>>>> Rami Rosen
>>>>
>>>>
>>>> Signed-off-by: Rami Rosen <rosenrami@gmail.com>
>>>>
>>>>       
>>> sctp_cmsg_data_t  is not used by kernel source code, but it still used
>>> by lksctp-tools.
>>>
>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>>     
>>
>>
>>   
> 
>