* [PATCH 2/4] [mtd] fixed faulty check
@ 2009-07-30 10:25 ` Stoyan Gaydarov
0 siblings, 0 replies; 4+ messages in thread
From: Stoyan Gaydarov @ 2009-07-30 10:25 UTC (permalink / raw)
To: linux-kernel
Cc: Stoyan Gaydarov, David.Woodhouse, bigeasy, kay.sievers, linux-mtd,
sr, gregkh
This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
---
drivers/mtd/maps/physmap_of.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index 39d357b..2cc0b0d 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -215,7 +215,7 @@ static int __devinit of_flash_probe(struct of_device *dev,
goto err_out;
mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
- if (!info)
+ if (!mtd_list)
goto err_out;
dev_set_drvdata(&dev->dev, info);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/4] [mtd] fixed faulty check
@ 2009-07-30 10:25 ` Stoyan Gaydarov
0 siblings, 0 replies; 4+ messages in thread
From: Stoyan Gaydarov @ 2009-07-30 10:25 UTC (permalink / raw)
To: linux-kernel
Cc: Stoyan Gaydarov, David.Woodhouse, sr, bigeasy, kay.sievers,
gregkh, linux-mtd
This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
---
drivers/mtd/maps/physmap_of.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index 39d357b..2cc0b0d 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -215,7 +215,7 @@ static int __devinit of_flash_probe(struct of_device *dev,
goto err_out;
mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
- if (!info)
+ if (!mtd_list)
goto err_out;
dev_set_drvdata(&dev->dev, info);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4] [mtd] fixed faulty check
2009-07-30 10:25 ` Stoyan Gaydarov
@ 2009-07-30 11:27 ` Sebastian Andrzej Siewior
-1 siblings, 0 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2009-07-30 11:27 UTC (permalink / raw)
To: Stoyan Gaydarov
Cc: kay.sievers, David.Woodhouse, gregkh, linux-kernel, linux-mtd, sr
Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
>
> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
> drivers/mtd/maps/physmap_of.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
> index 39d357b..2cc0b0d 100644
> --- a/drivers/mtd/maps/physmap_of.c
> +++ b/drivers/mtd/maps/physmap_of.c
> @@ -215,7 +215,7 @@ static int __devinit of_flash_probe(struct of_device *dev,
> goto err_out;
>
> mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
> - if (!info)
> + if (!mtd_list)
> goto err_out;
>
> dev_set_drvdata(&dev->dev, info);
Yes, !mtd_list should be checked instead of !info. This is correct.
However in error case you have to free info as well.
Can please make another patch?
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4] [mtd] fixed faulty check
@ 2009-07-30 11:27 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2009-07-30 11:27 UTC (permalink / raw)
To: Stoyan Gaydarov
Cc: linux-kernel, David.Woodhouse, sr, kay.sievers, gregkh, linux-mtd
Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
>
> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
> drivers/mtd/maps/physmap_of.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
> index 39d357b..2cc0b0d 100644
> --- a/drivers/mtd/maps/physmap_of.c
> +++ b/drivers/mtd/maps/physmap_of.c
> @@ -215,7 +215,7 @@ static int __devinit of_flash_probe(struct of_device *dev,
> goto err_out;
>
> mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
> - if (!info)
> + if (!mtd_list)
> goto err_out;
>
> dev_set_drvdata(&dev->dev, info);
Yes, !mtd_list should be checked instead of !info. This is correct.
However in error case you have to free info as well.
Can please make another patch?
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-30 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-30 10:25 [PATCH 2/4] [mtd] fixed faulty check Stoyan Gaydarov
2009-07-30 10:25 ` Stoyan Gaydarov
2009-07-30 11:27 ` Sebastian Andrzej Siewior
2009-07-30 11:27 ` Sebastian Andrzej Siewior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.