From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: vimal singh <vimal.newwork@gmail.com>
Cc: Stoyan Gaydarov <sgayda2@uiuc.edu>,
kay.sievers@vrfy.org, gregkh@suse.de,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
sr@denx.de, David.Woodhouse@intel.com
Subject: Re: [PATCH] [mtd] fixed faulty check
Date: Thu, 30 Jul 2009 15:47:47 +0200 [thread overview]
Message-ID: <4A71A483.30507@linutronix.de> (raw)
In-Reply-To: <ce9ab5790907300639k3173446csbd07198055bfe122@mail.gmail.com>
vimal singh wrote:
> What if you go to 'err_out' due to some other error?? Do not you need
> to free 'info'?
We have to and of_flash_remove() takes care of it.
The initial patch would be shorter if
dev_set_drvdata(&dev->dev, info);
would be moved prior the kzalloc()
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: vimal singh <vimal.newwork@gmail.com>
Cc: Stoyan Gaydarov <sgayda2@uiuc.edu>,
linux-kernel@vger.kernel.org, David.Woodhouse@intel.com,
sr@denx.de, kay.sievers@vrfy.org, gregkh@suse.de,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [mtd] fixed faulty check
Date: Thu, 30 Jul 2009 15:47:47 +0200 [thread overview]
Message-ID: <4A71A483.30507@linutronix.de> (raw)
In-Reply-To: <ce9ab5790907300639k3173446csbd07198055bfe122@mail.gmail.com>
vimal singh wrote:
> What if you go to 'err_out' due to some other error?? Do not you need
> to free 'info'?
We have to and of_flash_remove() takes care of it.
The initial patch would be shorter if
dev_set_drvdata(&dev->dev, info);
would be moved prior the kzalloc()
Sebastian
next prev parent reply other threads:[~2009-07-30 13:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 12:49 [PATCH] [mtd] fixed faulty check Stoyan Gaydarov
2009-07-30 12:49 ` Stoyan Gaydarov
2009-07-30 13:03 ` Sebastian Andrzej Siewior
2009-07-30 13:03 ` Sebastian Andrzej Siewior
2009-07-30 13:39 ` vimal singh
2009-07-30 13:39 ` vimal singh
2009-07-30 13:47 ` Sebastian Andrzej Siewior [this message]
2009-07-30 13:47 ` Sebastian Andrzej Siewior
2009-07-30 14:14 ` vimal singh
2009-07-30 14:14 ` vimal singh
[not found] ` <4A71AD5E.4080704@uiuc.edu>
2009-07-30 14:34 ` vimal singh
2009-07-30 14:34 ` vimal singh
2009-07-30 14:53 ` Sebastian Andrzej Siewior
2009-07-30 14:53 ` Sebastian Andrzej Siewior
2009-07-30 15:13 ` vimal singh
2009-07-30 15:13 ` vimal singh
[not found] ` <4A71B940.80607@uiuc.edu>
2009-07-30 15:24 ` vimal singh
2009-07-30 15:24 ` vimal singh
-- strict thread matches above, loose matches on Subject: below --
2009-07-30 14:47 Stoyan Gaydarov
2009-07-30 15:07 ` vimal singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71A483.30507@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=David.Woodhouse@intel.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sgayda2@uiuc.edu \
--cc=sr@denx.de \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.