Re: [PATCH] chunkd: configure now detects location of cld program

[Matthew Farrellee <matt@redhat.com>]

Jeff Garzik wrote:
> Matthew Farrellee wrote:
>> Jeff Garzik wrote:
>>> Matthew Farrellee wrote:
>>>> make check attempts to start cld, but cannot find it if it is not
>>>> already in PATH. This patch uses CLDC_PREFIX, possibly from
>>>> pkg-config, to detect the location of cld with configure.
>>>>
>>>> Signed-off-by: Matthew Farrellee <matt@redhat.com>
>>>> ---
>>>>  configure.ac              |   19 +++++++++++++++++++
>>>>  test/Makefile.am          |    1 +
>>>>  test/start-daemon         |   20 +-------------------
>>>>  test/start-daemon.real.in |   20 ++++++++++++++++++++
>>>>  4 files changed, 41 insertions(+), 19 deletions(-)
>>>>  create mode 100644 test/start-daemon.real.in
>>> oh, FYI:  this missed updating test/.gitignore to tell git to ignore the
>>> generated file.
>>>
>>> Typically you want to run "git status" after builds and such, to make
>>> sure that git is aware of the status of all files (in repo, or ignored).
>>>
>>> Running "git status" is a good habit to get into.  At least for me, I
>>> have sent out patches that accidentally omit newly added files, because
>>> I forgot to run "git status".
>>>
>>> Thanks!
>>>
>>>     Jeff
>>
>> So, I do run git status, but my normal workflow does not include heavy
>> use of .gitignore.
>>
>> I'm actually not a fan of this use of .gitignore, mostly because I
>> like git clean as a means to reset things.
> 
> I hear ya :)   But we do have non-git tarball users, which implies that
> "make distclean" should clean everything...   which implies truly
> needing to use 'git clean' is more a bug than a feature.
> 
> I wouldn't ask you to change your workflow, but 'git status' and 'make
> distclean' are the norm for these projects (as well as the kernel, where
> we have the actual git author critique us :))
> 
>     Jeff

I'd be nice if git-clean could be told to ignore the ignore file, ha. distclean doesn't clean up autotool file, like configure.

Best,


matt