All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Matthew Farrellee <matt@redhat.com>
Cc: hail-devel@vger.kernel.org
Subject: Re: [PATCH] chunkd: configure now detects location of cld program
Date: Wed, 29 Jul 2009 21:43:44 -0400	[thread overview]
Message-ID: <4A70FAD0.3000107@garzik.org> (raw)
In-Reply-To: <4A70BE6B.7070906@redhat.com>

Matthew Farrellee wrote:
> make check attempts to start cld, but cannot find it if it is not
> already in PATH. This patch uses CLDC_PREFIX, possibly from
> pkg-config, to detect the location of cld with configure.
> 
> Signed-off-by: Matthew Farrellee <matt@redhat.com>
> ---
>  configure.ac              |   19 +++++++++++++++++++
>  test/Makefile.am          |    1 +
>  test/start-daemon         |   20 +-------------------
>  test/start-daemon.real.in |   20 ++++++++++++++++++++
>  4 files changed, 41 insertions(+), 19 deletions(-)
>  create mode 100644 test/start-daemon.real.in

oh, FYI:  this missed updating test/.gitignore to tell git to ignore the 
generated file.

Typically you want to run "git status" after builds and such, to make 
sure that git is aware of the status of all files (in repo, or ignored).

Running "git status" is a good habit to get into.  At least for me, I 
have sent out patches that accidentally omit newly added files, because 
I forgot to run "git status".

Thanks!

	Jeff





  parent reply	other threads:[~2009-07-30  1:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 21:26 [PATCH] chunkd: configure now detects location of cld program Matthew Farrellee
2009-07-30  1:35 ` Jeff Garzik
2009-07-30 14:27   ` Matthew Farrellee
2009-07-30  1:43 ` Jeff Garzik [this message]
2009-07-30 14:28   ` Matthew Farrellee
2009-07-30 20:46     ` Jeff Garzik
2009-07-30 21:34       ` Matthew Farrellee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A70FAD0.3000107@garzik.org \
    --to=jeff@garzik.org \
    --cc=hail-devel@vger.kernel.org \
    --cc=matt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.