* [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast
@ 2009-07-31 19:28 Goldwyn Rodrigues
2009-07-31 19:39 ` Sunil Mushran
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Goldwyn Rodrigues @ 2009-07-31 19:28 UTC (permalink / raw)
To: ocfs2-devel
Remove redundant BUG_ON()
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
---
diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
index d07ddbe..81eff8e 100644
--- a/fs/ocfs2/dlm/dlmast.c
+++ b/fs/ocfs2/dlm/dlmast.c
@@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
lock->ast_pending, lock->ml.type);
BUG();
}
- BUG_ON(!list_empty(&lock->ast_list));
if (lock->ast_pending)
mlog(0, "lock has an ast getting flushed right now\n");
--
Goldwyn
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast
2009-07-31 19:28 [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast Goldwyn Rodrigues
@ 2009-07-31 19:39 ` Sunil Mushran
2009-07-31 20:10 ` Sunil Mushran
2009-07-31 20:48 ` Joel Becker
2 siblings, 0 replies; 4+ messages in thread
From: Sunil Mushran @ 2009-07-31 19:39 UTC (permalink / raw)
To: ocfs2-devel
Can you explain why you think it is redundant?
Goldwyn Rodrigues wrote:
> Remove redundant BUG_ON()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
> ---
>
> diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
> index d07ddbe..81eff8e 100644
> --- a/fs/ocfs2/dlm/dlmast.c
> +++ b/fs/ocfs2/dlm/dlmast.c
> @@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
> lock->ast_pending, lock->ml.type);
> BUG();
> }
> - BUG_ON(!list_empty(&lock->ast_list));
> if (lock->ast_pending)
> mlog(0, "lock has an ast getting flushed right now\n");
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast
2009-07-31 19:28 [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast Goldwyn Rodrigues
2009-07-31 19:39 ` Sunil Mushran
@ 2009-07-31 20:10 ` Sunil Mushran
2009-07-31 20:48 ` Joel Becker
2 siblings, 0 replies; 4+ messages in thread
From: Sunil Mushran @ 2009-07-31 20:10 UTC (permalink / raw)
To: ocfs2-devel
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Goldwyn Rodrigues wrote:
> Remove redundant BUG_ON()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
> ---
>
> diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
> index d07ddbe..81eff8e 100644
> --- a/fs/ocfs2/dlm/dlmast.c
> +++ b/fs/ocfs2/dlm/dlmast.c
> @@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
> lock->ast_pending, lock->ml.type);
> BUG();
> }
> - BUG_ON(!list_empty(&lock->ast_list));
> if (lock->ast_pending)
> mlog(0, "lock has an ast getting flushed right now\n");
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast
2009-07-31 19:28 [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast Goldwyn Rodrigues
2009-07-31 19:39 ` Sunil Mushran
2009-07-31 20:10 ` Sunil Mushran
@ 2009-07-31 20:48 ` Joel Becker
2 siblings, 0 replies; 4+ messages in thread
From: Joel Becker @ 2009-07-31 20:48 UTC (permalink / raw)
To: ocfs2-devel
On Fri, Jul 31, 2009 at 02:28:02PM -0500, Goldwyn Rodrigues wrote:
> Remove redundant BUG_ON()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
This is now in the fixes branch of ocfs2.git.
Joel
--
"Same dancers in the same old shoes.
You get too careful with the steps you choose.
You don't care about winning but you don't want to lose
After the thrill is gone."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-31 20:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-31 19:28 [Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast Goldwyn Rodrigues
2009-07-31 19:39 ` Sunil Mushran
2009-07-31 20:10 ` Sunil Mushran
2009-07-31 20:48 ` Joel Becker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.