From: Oliver Hartkopp <oliver@hartkopp.net>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Marcel Holtmann <marcel@holtmann.org>,
Linux Netdev List <netdev@vger.kernel.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: tty_register_device NULL pointer dereference in 2.6.31-rc4
Date: Sat, 01 Aug 2009 11:21:28 +0200 [thread overview]
Message-ID: <4A740918.1040504@hartkopp.net> (raw)
In-Reply-To: <20090801031705.GA2817@darkstar>
> --- linux-2.6.orig/include/net/bluetooth/rfcomm.h 2009-08-01 10:53:18.000000000 +0800
> +++ linux-2.6/include/net/bluetooth/rfcomm.h 2009-08-01 10:55:29.000000000 +0800
> @@ -355,7 +355,18 @@ struct rfcomm_dev_list_req {
> };
>
> int rfcomm_dev_ioctl(struct sock *sk, unsigned int cmd, void __user *arg);
> +
> +#ifdef CONFIG_BT_RFCOMM_TTY
> int rfcomm_init_ttys(void);
> void rfcomm_cleanup_ttys(void);
> -
> +#else
> +static inline int rfcomm_init_ttys(void)
> +{
> + return 0;
> +}
> +static inline int rfcomm_cleanup_ttys(void)
> +{
> + return 0;
> +}
> +#endif
Just a minor thing:
Does rfcomm_cleanup_ttys() return 'int' or is it 'void' ?
Regards,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Hartkopp <oliver-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
To: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
Linux Netdev List
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: tty_register_device NULL pointer dereference in 2.6.31-rc4
Date: Sat, 01 Aug 2009 11:21:28 +0200 [thread overview]
Message-ID: <4A740918.1040504@hartkopp.net> (raw)
In-Reply-To: <20090801031705.GA2817@darkstar>
> --- linux-2.6.orig/include/net/bluetooth/rfcomm.h 2009-08-01 10:53:18.000000000 +0800
> +++ linux-2.6/include/net/bluetooth/rfcomm.h 2009-08-01 10:55:29.000000000 +0800
> @@ -355,7 +355,18 @@ struct rfcomm_dev_list_req {
> };
>
> int rfcomm_dev_ioctl(struct sock *sk, unsigned int cmd, void __user *arg);
> +
> +#ifdef CONFIG_BT_RFCOMM_TTY
> int rfcomm_init_ttys(void);
> void rfcomm_cleanup_ttys(void);
> -
> +#else
> +static inline int rfcomm_init_ttys(void)
> +{
> + return 0;
> +}
> +static inline int rfcomm_cleanup_ttys(void)
> +{
> + return 0;
> +}
> +#endif
Just a minor thing:
Does rfcomm_cleanup_ttys() return 'int' or is it 'void' ?
Regards,
Oliver
next prev parent reply other threads:[~2009-08-01 9:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 10:01 tty_register_device NULL pointer dereference in 2.6.31-rc4 Oliver Hartkopp
2009-07-25 10:50 ` Alan Cox
2009-07-25 11:07 ` Marcel Holtmann
2009-07-25 12:10 ` Alan Cox
2009-07-25 12:10 ` Alan Cox
2009-07-27 9:59 ` Dave Young
2009-07-27 9:59 ` Dave Young
2009-07-27 11:12 ` Oliver Hartkopp
2009-07-27 11:39 ` Oliver Hartkopp
2009-07-27 14:07 ` Dave Young
2009-07-27 14:07 ` Dave Young
2009-07-29 14:00 ` Oliver Hartkopp
2009-07-30 9:15 ` Dave Young
2009-07-30 10:05 ` Oliver Hartkopp
2009-07-31 9:39 ` Dave Young
2009-07-31 9:39 ` Dave Young
2009-07-31 10:10 ` Dave Young
2009-07-31 10:10 ` Dave Young
2009-07-31 11:20 ` Oliver Hartkopp
2009-08-01 3:17 ` Dave Young
2009-08-01 3:17 ` Dave Young
2009-08-01 9:15 ` Oliver Hartkopp
2009-08-01 9:21 ` Oliver Hartkopp [this message]
2009-08-01 9:21 ` Oliver Hartkopp
2009-08-01 9:32 ` Dave Young
2009-08-03 12:03 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A740918.1040504@hartkopp.net \
--to=oliver@hartkopp.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hidave.darkstar@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.