From: "Thomas Hellström" <thellstrom@vmware.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"venkatesh.pallipadi@intel.com" <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH] x86: Use clflush() instead of wbinvd() whenever possible when changing mapping
Date: Sun, 02 Aug 2009 18:22:02 +0200 [thread overview]
Message-ID: <4A75BD2A.9050404@vmware.com> (raw)
In-Reply-To: <20090730090747.GD1364@ucw.cz>
Pavel Machek skrev:
> On Fri 2009-07-24 09:53:01, Thomas Hellstrom wrote:
>
>> The current code uses wbinvd() when the area to flush is > 4MB. Although this
>> may be faster than using clflush() the effect of wbinvd() on irq
>> latencies
>>
>
> You are slowing the kernel down, and you did not write down the
> reasons. bad.
>
>
I may slow the kernel down or speed it up depending on your hardware
configuration. The reasons should be quite obvious if you read the
discussion following the patch.
/Thomas
prev parent reply other threads:[~2009-08-02 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 7:53 [PATCH] x86: Use clflush() instead of wbinvd() whenever possible when changing mapping Thomas Hellstrom
2009-07-24 10:05 ` Andi Kleen
2009-07-24 10:21 ` Thomas Hellstrom
2009-07-24 10:58 ` Andi Kleen
2009-07-24 11:14 ` Thomas Hellstrom
2009-07-24 13:16 ` Andi Kleen
2009-07-30 9:07 ` Pavel Machek
2009-08-02 16:22 ` Thomas Hellström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A75BD2A.9050404@vmware.com \
--to=thellstrom@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.