All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	venkatesh.pallipadi@intel.com
Subject: Re: [PATCH] x86: Use clflush() instead of wbinvd() whenever possible when changing mapping
Date: Fri, 24 Jul 2009 12:05:01 +0200	[thread overview]
Message-ID: <87ocra1jn6.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1248421981-31865-1-git-send-email-thellstrom@vmware.com> (Thomas Hellstrom's message of "Fri, 24 Jul 2009 09:53:01 +0200")

Thomas Hellstrom <thellstrom@vmware.com> writes:

> The current code uses wbinvd() when the area to flush is > 4MB. Although this
> may be faster than using clflush() the effect of wbinvd() on irq latencies
> may be catastrophical on systems with large caches. Therefore use clflush()

may be? You seem to miss some hard data here.

I wouldn't expect wbinvd to take longer than a ms or two, which 
is probably not catastrophic yet.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-07-24 10:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  7:53 [PATCH] x86: Use clflush() instead of wbinvd() whenever possible when changing mapping Thomas Hellstrom
2009-07-24 10:05 ` Andi Kleen [this message]
2009-07-24 10:21   ` Thomas Hellstrom
2009-07-24 10:58     ` Andi Kleen
2009-07-24 11:14       ` Thomas Hellstrom
2009-07-24 13:16         ` Andi Kleen
2009-07-30  9:07 ` Pavel Machek
2009-08-02 16:22   ` Thomas Hellström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocra1jn6.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=thellstrom@vmware.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.