All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: John Dykstra <john.dykstra1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile
Date: Tue, 04 Aug 2009 04:20:45 -0400	[thread overview]
Message-ID: <4A77EF5D.7070501@librato.com> (raw)
In-Reply-To: <1249328610.7138.23.camel@Maple>



John Dykstra wrote:
> Oren, I'm not sure who you're accepting patches from, but...

I accept any good patch  :)
(pushed to ckpt-v17-dev)

Oren.


> 
> --
> Kernel builds that specify targets in the checkpoint/ directory will
> fail or be incorrect because the autoconfig files were not included.
> One way to reproduce the problem is:
> 
> 	make checkpoint/sys.s
> 
> The problem is that this pattern in linux/Makefile matches files in the
> checkpoint/ directory:
> 
> no-dot-config-targets := clean mrproper distclean \
>                          cscope TAGS tags help %docs check% \
>                          include/linux/version.h headers_% \
>                          kernelrelease kernelversion
> 
> Make the pattern more exact, per the current set of linux build targets.
> 
> Signed-off-by: John Dykstra <john.dykstra1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index cf631d7..17445a6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -400,7 +400,7 @@ endif
>  # of make so .config is not included in this case either (for *config).
>  
>  no-dot-config-targets := clean mrproper distclean \
> -			 cscope TAGS tags help %docs check% \
> +			 cscope TAGS tags help %docs checkstack \
>  			 include/linux/version.h headers_% \
>  			 kernelrelease kernelversion
>  

  reply	other threads:[~2009-08-04  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 19:43 [PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile John Dykstra
2009-08-04  8:20 ` Oren Laadan [this message]
     [not found]   ` <4A77EF5D.7070501-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-08-04 14:50     ` John Dykstra
2009-08-04 17:07       ` Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A77EF5D.7070501@librato.com \
    --to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
    --cc=Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=john.dykstra1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.