From: Andi Kleen <ak@linux.intel.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: "H.Peter Anvin" <hpa@zytor.com>,
LKLM <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Huang Ying <ying.huang@intel.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: Re: [PATCH] x86, mce: cleanup initcall of debugfs for mce
Date: Tue, 04 Aug 2009 11:18:04 +0200 [thread overview]
Message-ID: <4A77FCCC.7040608@linux.intel.com> (raw)
In-Reply-To: <4A77CEAB.4030909@np.css.fujitsu.com>
> int mce_severity(struct mce *a, int tolerant, char **msg);
> -struct dentry *mce_get_debugfs_dir(void);
> +int __init severities_debugfs_init(struct dentry *dmce);
__init is not needed on prototypes.
Sorry but I think it's better to have an own initcall per file,
that makes everything more self contained and easier to read.
-Andi
next prev parent reply other threads:[~2009-08-04 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 6:01 [PATCH] x86, mce: cleanup initcall of debugfs for mce Jin Dongming
2009-08-04 9:18 ` Andi Kleen [this message]
2009-08-05 9:01 ` Jin Dongming
2009-08-05 12:48 ` Andi Kleen
2009-08-06 0:22 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A77FCCC.7040608@linux.intel.com \
--to=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.