All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: "H.Peter Anvin" <hpa@zytor.com>,
	LKLM <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Huang Ying <ying.huang@intel.com>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: Re: [PATCH] x86, mce: cleanup initcall of debugfs for mce
Date: Wed, 05 Aug 2009 14:48:21 +0200	[thread overview]
Message-ID: <4A797F95.30906@linux.intel.com> (raw)
In-Reply-To: <4A794A4E.2060802@np.css.fujitsu.com>

Jin Dongming wrote:
> Andi Kleen wrote:
>> Sorry but I think it's better to have an own initcall per file,
>> that makes everything more self contained and easier to read.
>>
>> -Andi
>>
> Thank you for your comment.
> 
> That's OK, but this patch is also used for resolving compile error
> without CONFIG_DEBUG_FS.  Then how about this patch?


Compiler errors should be always fixed of course. But did you check
the compile error is still in the latest version of the x86/mce branch
of
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-tip.git
It might be fixed already.

-Andi


  reply	other threads:[~2009-08-05 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-04  6:01 [PATCH] x86, mce: cleanup initcall of debugfs for mce Jin Dongming
2009-08-04  9:18 ` Andi Kleen
2009-08-05  9:01   ` Jin Dongming
2009-08-05 12:48     ` Andi Kleen [this message]
2009-08-06  0:22       ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A797F95.30906@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jin.dongming@np.css.fujitsu.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.