[PATCH] fix libicu compilation with GCC-4.4 on mips

[PATCH] fix libicu compilation with GCC-4.4 on mips

[Graham Gower]

Not sure if this one is mips specific or not, but linking fails due to
missing -fPIC on rematch.o.
| /home/grg/oe/tmp/cross/mipsel/lib/gcc/mipsel-angstrom-linux/4.4.1/../../../../mipsel-angstrom-linux/bin/ld: rematch.o: relocation R_MIPS_HI16 against `__gnu_local_gp' can not be used when making a shared object; recompile with -fPIC

Perhaps someone who experienced the (arm specific?) gcc bug mentioned in
commit 798c780a3a016e56d9b8849cf8a07521b6e402a9 can confirm this fix does
not trigger the same bug?

-Graham

diff --git a/recipes/icu/files/rematch-gcc-bug.patch b/recipes/icu/files/rematch-gcc-bug.patch
index 4d47056..5f516e3 100644
--- a/recipes/icu/files/rematch-gcc-bug.patch
+++ b/recipes/icu/files/rematch-gcc-bug.patch
@@ -5,7 +5,7 @@
  all-local: $(ALL_TARGETS)
  
 +rematch.o: $(srcdir)/rematch.cpp
-+	$(CXX) $(CPPFLAGS) $(DEFS) -c -o $@ $<
++	$(CXX) -fPIC $(CPPFLAGS) $(DEFS) -c -o $@ $<
 +
  install-local: install-headers install-library
  

Re: [PATCH] fix libicu compilation with GCC-4.4 on mips

[Holger Hans Peter Freyther]

On Wednesday 05 August 2009 02:28:55 Graham Gower wrote:
> Not sure if this one is mips specific or not, but linking fails due to
> missing -fPIC on rematch.o.
>
> | /home/grg/oe/tmp/cross/mipsel/lib/gcc/mipsel-angstrom-linux/4.4.1/../../.
> |./../mipsel-angstrom-linux/bin/ld: rematch.o: relocation R_MIPS_HI16
> | against `__gnu_local_gp' can not be used when making a shared object;
> | recompile with -fPIC
>
> Perhaps someone who experienced the (arm specific?) gcc bug mentioned in
> commit 798c780a3a016e56d9b8849cf8a07521b6e402a9 can confirm this fix does
> not trigger the same bug?


i will test an arm build for you.

Signed-Off-By: Holger Hans Peter Freyther <holger@freyther.de>

Re: [PATCH] fix libicu compilation with GCC-4.4 on mips

[Holger Hans Peter Freyther]

On Sunday 09 August 2009 15:45:01 Holger Hans Peter Freyther wrote:

> Signed-Off-By: Holger Hans Peter Freyther <holger@freyther.de>

Applied, it would be cool if you could use git format-patch in the future to 
safe me some time to apply and commit the patch.

z.