* [U-Boot] unused dhcp option?
[not found] <200908061322.44082.rgetz@blackfin.uclinux.org>
@ 2009-08-06 17:28 ` Ben Warren
0 siblings, 0 replies; only message in thread
From: Ben Warren @ 2009-08-06 17:28 UTC (permalink / raw)
To: u-boot
Hi Robin,
Robin Getz wrote:
> As far as I can tell - the dhcp_leasetime var is not accessed outside of the
> net/bootp.c file, and it isn't actually used anywhere, just written to - so
> it is not removed by --gc-sections. :(
>
> net/bootp.c:unsigned long dhcp_leasetime = 0;
>
> net/bootp.c: NetCopyLong (&dhcp_leasetime, (ulong *) (popt + 2));
>
> So, it should be declared as static, or removed completely -- which do you
> prefer? (for size - I would prefer punt).
>
> -Robin
>
Yeah, looks like it's not referenced anywhere. I say replace it with a
comment like so many other parts of the packet:
/* Ignore Lease Time Field*/
regards,
Ben
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-08-06 17:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200908061322.44082.rgetz@blackfin.uclinux.org>
2009-08-06 17:28 ` [U-Boot] unused dhcp option? Ben Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.