From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] PLATFORM_CPPFLAGS ?
Date: Thu, 06 Aug 2009 13:12:11 -0500 [thread overview]
Message-ID: <4A7B1CFB.3030905@freescale.com> (raw)
Why do we define the same macros in config.mk and in the board header file?
config.mk:
PLATFORM_CPPFLAGS += -DCONFIG_E500=1
PLATFORM_CPPFLAGS += -DCONFIG_MPC85xx=1
PLATFORM_CPPFLAGS += -DCONFIG_MPC8572=1
MPC8572DS.h:
#define CONFIG_BOOKE 1 /* BOOKE */
#define CONFIG_E500 1 /* BOOKE e500 family */
#define CONFIG_MPC85xx 1 /* MPC8540/60/55/41/48 */
#define CONFIG_MPC8572 1
Isn't it redundant to have these entries in config.mk? We seem to be doing this more and more, but config.mk is always board-specific, just like MPC8572DS.h.
--
Timur Tabi
Linux kernel developer at Freescale
next reply other threads:[~2009-08-06 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 18:12 Timur Tabi [this message]
2009-08-06 19:40 ` [U-Boot] PLATFORM_CPPFLAGS ? Wolfgang Denk
2009-08-06 21:28 ` Kumar Gala
2009-08-06 21:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7B1CFB.3030905@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.