From: Christian Tramnitz <chris.ace@gmx.net>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] fix ioemu build
Date: Fri, 07 Aug 2009 00:44:48 +0200 [thread overview]
Message-ID: <4A7B5CE0.8080907@gmx.net> (raw)
In-Reply-To: <C6A11819.1191C%keir.fraser@eu.citrix.com>
Keir Fraser wrote:
>> Anyway checking for the existence of a file before actually deleting it
>> shouldn't really hurt...
>
> But... 'rm -f' doesn't fail when the file doesn't exist?
It doesn't, but under circumstances this is escaping the sandbox and
generating an access violation.
This was initially reported for 3.3.1 as gentoo bug and fixed with this
patch. Now I'm trying to get the live ebuilds working but patching is
not an option there...
Details are available here:
http://bugs.gentoo.org/262124
Not really sure if this only manifests itself in the gentoo build
environment, but since other places in xen-setup check for the existence
of the file before doing sth with it, I don't think it would hurt to apply.
Btw, the path in my patch was wrong, I guess it should be
qemu-xen-unstable instead of ioemu-dir.
Best regards,
Christian
next prev parent reply other threads:[~2009-08-06 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 22:04 [PATCH] fix ioemu build Christian Tramnitz
2009-08-06 22:30 ` Keir Fraser
2009-08-06 22:44 ` Christian Tramnitz [this message]
2009-08-10 15:06 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7B5CE0.8080907@gmx.net \
--to=chris.ace@gmx.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.