Re: [Patch 3/10] NFS Mount Configuration File (Vers 3)

[Benny Halevy <bhalevy@panasas.com>]

On Aug. 06, 2009, 21:42 +0300, Steve Dickson <SteveD@redhat.com> wrote:
> commit 3d08862cfebb9fb8a360d362bb9e5e761e6b1fb5
> Author: Steve Dickson <steved@redhat.com>
> Date:   Wed Aug 5 15:53:36 2009 -0400
> 
>     Make Section names case-insensitive which should
>     help in locating them resulting in make the config
>     files a bit less error prone
>     
>     Signed-off-by: Steve Dickson <steved@redhat.com>
> 
> diff --git a/support/nfs/conffile.c b/support/nfs/conffile.c
> index 5f491eb..a8b8037 100644
> --- a/support/nfs/conffile.c
> +++ b/support/nfs/conffile.c
> @@ -116,6 +116,18 @@ conf_hash(char *s)
>  }
>  
>  /*
> + * Convert letter from upper case to lower case
> + */
> +static inline void upper2lower(char *str)
> +{
> +	char *ptr = str;
> +
> +	while (*ptr) 
> +		*ptr++ = tolower(*ptr);
> +}
> +

nit: to optimize this function a tiny bit you can also do:

static inline void upper2lower(char *str)
{
	char c;

	while ((c = tolower(*str)))
		*str++ = c;
}

Benny

> +
> +/*
>   * Insert a tag-value combination from LINE (the equal sign is at POS)
>   */
>  static int
> @@ -654,6 +666,9 @@ conf_set(int transaction, char *section, char *tag,
>  		xlog_warn("conf_set: strdup(\"%s\") failed", section);
>  		goto fail;
>  	}
> +	/* Make Section names case-insensitive */
> +	upper2lower(node->section);
> +
>  	node->tag = strdup(tag);
>  	if (!node->tag) {
>  		xlog_warn("conf_set: strdup(\"%s\") failed", tag);
> 
> _______________________________________________
> NFSv4 mailing list
> NFSv4@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4