From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>,
Linux NFSv4 mailing list <nfsv4@linux-nfs.org>
Subject: Re: [Patch 6/10] NFS Mount Configuration File (Vers 3)
Date: Fri, 07 Aug 2009 13:34:12 -0400 [thread overview]
Message-ID: <4A7C6594.7040700@RedHat.com> (raw)
In-Reply-To: <95B06B96-FCFB-49FA-ACA6-3E336DB5BE33@oracle.com>
On 08/06/2009 04:44 PM, Chuck Lever wrote:
>
> Seems to me the text-based mount option parser routines (parse_opt.[ch])
> already does a lot of this. It can break up a string into a linked list
> of options, handle quoted commas properly, catenate options to the list,
> and flatten the list back into a C string.
Well I patterned the code after the file parsing code in idmap daemon
which means there a common theme between both the idmap configuration
file and the mount configuration. I think that is important.
>
> Wouldn't it be easier to adapt that code rather than adding new code
> that does nearly the same thing? It would save you a lot of C string
> manipulation, and reuse working code.
At this point, no. and I am reuse a lot of code...
steved.
next prev parent reply other threads:[~2009-08-07 17:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 18:38 [Patch 0/10] NFS Mount Configuration File (Vers 3) Steve Dickson
2009-08-06 18:40 ` [Patch 1/10] " Steve Dickson
2009-08-07 8:06 ` Benny Halevy
2009-08-07 17:09 ` Steve Dickson
2009-08-06 18:42 ` [Patch 3/10] " Steve Dickson
2009-08-07 7:38 ` Benny Halevy
2009-08-07 17:13 ` Steve Dickson
2009-08-07 18:35 ` Steve Dickson
2009-08-08 20:54 ` Benny Halevy
2009-08-06 18:43 ` [Patch 4/10] " Steve Dickson
2009-08-06 18:45 ` [Patch 6/10] " Steve Dickson
2009-08-06 20:44 ` Chuck Lever
2009-08-07 17:34 ` Steve Dickson [this message]
2009-08-06 18:46 ` [Patch 7/10] " Steve Dickson
[not found] ` <4A7B2515.2040304-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-08-06 20:35 ` Chuck Lever
2009-08-07 17:17 ` Steve Dickson
2009-08-07 18:37 ` Steve Dickson
[not found] ` <4A7B2324.9090406-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-08-06 18:41 ` [Patch 2/10] " Steve Dickson
[not found] ` <4A7B23D2.6080900-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-08-07 8:07 ` Benny Halevy
2009-08-07 17:11 ` Steve Dickson
[not found] ` <4A7C6032.4060301-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-08-08 20:52 ` Benny Halevy
2009-08-06 18:44 ` [Patch 5/10] " Steve Dickson
2009-08-06 18:47 ` [Patch 8/10] " Steve Dickson
2009-08-06 18:48 ` [Patch 9/10] " Steve Dickson
2009-08-06 18:49 ` [Patch 10/10] " Steve Dickson
2009-08-17 13:12 ` [Patch 0/10] " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7C6594.7040700@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.