question about drivers/scsi/aic7xxx/aic79xx_pci.c

question about drivers/scsi/aic7xxx/aic79xx_pci.c

[Julia Lawall]

In the file drivers/scsi/aic7xxx/aic79xx_pci.c, the function 
ahd_aic790X_setup contains the code:

                ahd->features |= AHD_RTI|AHD_NEW_IOCELL_OPTS
                              |  AHD_NEW_DFCNTRL_OPTS|AHD_FAST_CDB_DELIVERY
                              |  AHD_BUSFREEREV_BUG;
                ahd->bugs |= AHD_LQOOVERRUN_BUG|AHD_EARLY_REQ_BUG;

Should AHD_BUSFREEREV_BUG be moved from ahd->features to ahd->bugs?

julia

Re: question about drivers/scsi/aic7xxx/aic79xx_pci.c

[James Bottomley]

On Wed, 2009-07-29 at 19:09 +0200, Julia Lawall wrote:
> In the file drivers/scsi/aic7xxx/aic79xx_pci.c, the function 
> ahd_aic790X_setup contains the code:
> 
>                 ahd->features |= AHD_RTI|AHD_NEW_IOCELL_OPTS
>                               |  AHD_NEW_DFCNTRL_OPTS|AHD_FAST_CDB_DELIVERY
>                               |  AHD_BUSFREEREV_BUG;
>                 ahd->bugs |= AHD_LQOOVERRUN_BUG|AHD_EARLY_REQ_BUG;
> 
> Should AHD_BUSFREEREV_BUG be moved from ahd->features to ahd->bugs?

In theory, yes.  In practice, it's harmless in features since the value
is above any feature flag.  The question is whether the B rev boards
actually might work better (or worse) with this, since they've been
operating without it for decades ... do we have any to test?

James

Re: question about drivers/scsi/aic7xxx/aic79xx_pci.c

[Hannes Reinecke]

James Bottomley wrote:
> On Wed, 2009-07-29 at 19:09 +0200, Julia Lawall wrote:
>> In the file drivers/scsi/aic7xxx/aic79xx_pci.c, the function 
>> ahd_aic790X_setup contains the code:
>>
>>                 ahd->features |= AHD_RTI|AHD_NEW_IOCELL_OPTS
>>                               |  AHD_NEW_DFCNTRL_OPTS|AHD_FAST_CDB_DELIVERY
>>                               |  AHD_BUSFREEREV_BUG;
>>                 ahd->bugs |= AHD_LQOOVERRUN_BUG|AHD_EARLY_REQ_BUG;
>>
>> Should AHD_BUSFREEREV_BUG be moved from ahd->features to ahd->bugs?
> 
> In theory, yes.  In practice, it's harmless in features since the value
> is above any feature flag.  The question is whether the B rev boards
> actually might work better (or worse) with this, since they've been
> operating without it for decades ... do we have any to test?
> 
I have some. If you can tell me how to detect them I'll have a look.

Cheers,

Hannes
---
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html