* [PATCH] b43: Fix a typo in the sync_stx routine
@ 2009-08-10 22:54 Gábor Stefanik
2009-08-10 23:14 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Gábor Stefanik @ 2009-08-10 22:54 UTC (permalink / raw)
To: John Linville, Michael Buesch
Cc: Larry Finger, Broadcom Wireless, linux-wireless
I completely missed the "one's complement" instruction from the specs.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
drivers/net/wireless/b43/phy_lp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 46fe476..34ad738 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
tmp >>= e->rf_shift;
tmp <<= e->phy_shift;
b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
- e->mask << e->phy_shift, tmp);
+ ~(e->mask << e->phy_shift), tmp);
}
}
--
1.6.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] b43: Fix a typo in the sync_stx routine
2009-08-10 22:54 [PATCH] b43: Fix a typo in the sync_stx routine Gábor Stefanik
@ 2009-08-10 23:14 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2009-08-10 23:14 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Michael Buesch, Broadcom Wireless, linux-wireless
Gábor Stefanik wrote:
> I completely missed the "one's complement" instruction from the specs.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> drivers/net/wireless/b43/phy_lp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 46fe476..34ad738 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
> tmp >>= e->rf_shift;
> tmp <<= e->phy_shift;
> b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
> - e->mask << e->phy_shift, tmp);
> + ~(e->mask << e->phy_shift), tmp);
> }
> }
>
I should have caught that one.
When debugging gets started, it might be useful to add a statement
WARN_ON(mask & set);
at the start of b43_radio_maskset() and b43_phy_maskset(). That way
these kind of mistakes will be caught early.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-10 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-10 22:54 [PATCH] b43: Fix a typo in the sync_stx routine Gábor Stefanik
2009-08-10 23:14 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.