From: Neil Turton <nturton@solarflare.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Richard Bowser <bowser.richard@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: Guidance needed
Date: Tue, 11 Aug 2009 09:48:13 +0100 [thread overview]
Message-ID: <4A81304D.4000106@solarflare.com> (raw)
In-Reply-To: <C6A6022A.11D27%keir.fraser@eu.citrix.com>
Keir Fraser wrote:
> On 10/08/2009 16:48, "Richard Bowser" <bowser.richard@gmail.com> wrote:
>> The ketchup untar function holds this code:
>> err = os.system("mv linux*/* linux*/.[^.]* ..; rmdir linux*")
>> if err:
>> error("ketchup: Unpacking failed: ", err)
>> sys.exit(-1)
>>
>> I believe the printed 256 above is the hex value passed as "err".
>
> Er, well it looks like its trying to copy the non-file '..'. That fails and
> so the 'mv' fails and so the following 'rmdir' fails too. I'm not sure why
> it would try to copy '..' as the shell regexp (.[^.]*) appears to explicitly
> exclude it.
The second glob excludes it but the first will match it if dotglob gets
set somehow.
Try inserting '[^.]':
err = os.system("mv linux*/[^.]* linux*/.[^.]* ..; rmdir linux*")
Cheers, Neil.
prev parent reply other threads:[~2009-08-11 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 15:48 Guidance needed Richard Bowser
2009-08-10 15:58 ` Keir Fraser
2009-08-11 8:48 ` Neil Turton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A81304D.4000106@solarflare.com \
--to=nturton@solarflare.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=bowser.richard@gmail.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.