From: Roel Kluin <roel.kluin@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Prevent read buffer overflow
Date: Tue, 11 Aug 2009 20:40:30 +0200 [thread overview]
Message-ID: <4A81BB1E.6040904@gmail.com> (raw)
Prevent a read from valid_rate_index[] with a negative index
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Maybe we should add this?
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index ba06e78..a67b7f6 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -1458,7 +1458,7 @@ static void ath_rc_init(struct ath_softc *sc,
ath_rc_priv->rate_max_phy = ath_rc_priv->valid_phy_rateidx[i][j-1];
}
ASSERT(ath_rc_priv->rate_table_size <= RATE_TABLE_SIZE);
- ASSERT(k <= RATE_TABLE_SIZE);
+ ASSERT(k <= RATE_TABLE_SIZE && k >= 4);
ath_rc_priv->max_valid_rate = k;
ath_rc_sort_validrates(rate_table, ath_rc_priv);
WARNING: multiple messages have this Message-ID (diff)
From: Roel Kluin <roel.kluin@gmail.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] ath9k: Prevent read buffer overflow
Date: Tue, 11 Aug 2009 20:40:30 +0200 [thread overview]
Message-ID: <4A81BB1E.6040904@gmail.com> (raw)
Prevent a read from valid_rate_index[] with a negative index
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Maybe we should add this?
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index ba06e78..a67b7f6 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -1458,7 +1458,7 @@ static void ath_rc_init(struct ath_softc *sc,
ath_rc_priv->rate_max_phy = ath_rc_priv->valid_phy_rateidx[i][j-1];
}
ASSERT(ath_rc_priv->rate_table_size <= RATE_TABLE_SIZE);
- ASSERT(k <= RATE_TABLE_SIZE);
+ ASSERT(k <= RATE_TABLE_SIZE && k >= 4);
ath_rc_priv->max_valid_rate = k;
ath_rc_sort_validrates(rate_table, ath_rc_priv);
next reply other threads:[~2009-08-11 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 18:40 Roel Kluin [this message]
2009-08-11 18:40 ` [PATCH] ath9k: Prevent read buffer overflow Roel Kluin
2009-08-12 11:58 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2009-08-12 11:58 ` Vasanthakumar Thiagarajan
2009-08-12 12:35 ` [ath9k-devel] " roel kluin
2009-08-12 12:35 ` roel kluin
2009-08-12 12:42 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2009-08-12 12:42 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A81BB1E.6040904@gmail.com \
--to=roel.kluin@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.