From: Jiri Slaby <jirislaby@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath5k: fix requested allocated RX skb size for DMA
Date: Wed, 12 Aug 2009 20:13:30 +0200 [thread overview]
Message-ID: <4A83064A.2080609@gmail.com> (raw)
In-Reply-To: <1250096290-11058-1-git-send-email-lrodriguez@atheros.com>
On 08/12/2009 06:58 PM, Luis R. Rodriguez wrote:
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1157,17 +1157,18 @@ struct sk_buff *ath5k_rx_skb_alloc(struct ath5k_softc *sc, dma_addr_t *skb_addr)
> * fake physical layer header at the start.
> */
> skb = ath_rxbuf_alloc(&sc->common,
> - sc->rxbufsize + sc->common.cachelsz - 1,
What was the exact purpose of this? My guess is that we should map
starting at a next cache line boundary and put this aligned address to
the device instead?
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, ath5k-devel@lists.ath5k.org,
Nick Kossifidis <mickflemm@gmail.com>,
Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH] ath5k: fix requested allocated RX skb size for DMA
Date: Wed, 12 Aug 2009 20:13:30 +0200 [thread overview]
Message-ID: <4A83064A.2080609@gmail.com> (raw)
In-Reply-To: <1250096290-11058-1-git-send-email-lrodriguez@atheros.com>
On 08/12/2009 06:58 PM, Luis R. Rodriguez wrote:
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1157,17 +1157,18 @@ struct sk_buff *ath5k_rx_skb_alloc(struct ath5k_softc *sc, dma_addr_t *skb_addr)
> * fake physical layer header at the start.
> */
> skb = ath_rxbuf_alloc(&sc->common,
> - sc->rxbufsize + sc->common.cachelsz - 1,
What was the exact purpose of this? My guess is that we should map
starting at a next cache line boundary and put this aligned address to
the device instead?
next prev parent reply other threads:[~2009-08-12 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 16:58 [ath9k-devel] [PATCH] ath5k: fix requested allocated RX skb size for DMA Luis R. Rodriguez
2009-08-12 16:58 ` Luis R. Rodriguez
2009-08-12 18:13 ` Jiri Slaby [this message]
2009-08-12 18:13 ` Jiri Slaby
2009-08-12 18:48 ` [ath9k-devel] " Luis R. Rodriguez
2009-08-12 18:48 ` Luis R. Rodriguez
2009-08-12 21:08 ` Bob Copeland
2009-08-12 21:08 ` Bob Copeland
2009-08-13 3:33 ` Luis R. Rodriguez
2009-08-13 3:33 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A83064A.2080609@gmail.com \
--to=jirislaby@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.