From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] switch balloon initialization to -device.
Date: Fri, 14 Aug 2009 12:10:02 +0200 [thread overview]
Message-ID: <4A8537FA.9090404@redhat.com> (raw)
In-Reply-To: <87tz0alogm.fsf@pike.pond.sub.org>
On 08/14/09 11:44, Markus Armbruster wrote:
> Gerd Hoffmann<kraxel@redhat.com> writes:
>
>> With that patch applied "-balloon virtio,args" becomes a shortcut for
>> "-device virtio-balloon-pci,args".
>>
>> Side effects:
>> - ballon device gains support for id=<tag>.
>> - ballon device is off by default now.
>> - initialization order changes, which may in different pci slot
>> assignment depending on the VM configuration.
>>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>
> Looks good on quick inspection (gotta run), just one question: what
> happens when I (stupidly) do -balloon virtio,driver=e1000 ? Question
> might apply to plain -device before this patch as well.
QemuOpts allows overwriting, so who is written last will win.
Write order is undefined, so don't try that at home ;)
Behavior of the current code:
-balloon virtio,driver=e1000 will give you a balloon device.
-device virtio-blk-pci,driver=e1000 will give you a e1000.
cheers,
Gerd
next prev parent reply other threads:[~2009-08-14 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 8:34 [Qemu-devel] [PATCH] switch balloon initialization to -device Gerd Hoffmann
2009-08-14 9:44 ` Markus Armbruster
2009-08-14 10:10 ` Gerd Hoffmann [this message]
2009-08-21 15:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8537FA.9090404@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.