All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] switch balloon initialization to -device.
Date: Fri, 14 Aug 2009 11:44:09 +0200	[thread overview]
Message-ID: <87tz0alogm.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <1250238862-1408-1-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Fri\, 14 Aug 2009 10\:34\:22 +0200")

Gerd Hoffmann <kraxel@redhat.com> writes:

> With that patch applied "-balloon virtio,args" becomes a shortcut for
> "-device virtio-balloon-pci,args".
>
> Side effects:
>  - ballon device gains support for id=<tag>.
>  - ballon device is off by default now.
>  - initialization order changes, which may in different pci slot
>    assignment depending on the VM configuration.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Looks good on quick inspection (gotta run), just one question: what
happens when I (stupidly) do -balloon virtio,driver=e1000 ?  Question
might apply to plain -device before this patch as well.

  reply	other threads:[~2009-08-14  9:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14  8:34 [Qemu-devel] [PATCH] switch balloon initialization to -device Gerd Hoffmann
2009-08-14  9:44 ` Markus Armbruster [this message]
2009-08-14 10:10   ` Gerd Hoffmann
2009-08-21 15:59     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tz0alogm.fsf@pike.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.