From: Johannes Sixt <j.sixt@viscovery.net>
To: msysGit <msysgit@googlegroups.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h
Date: Tue, 18 Aug 2009 09:15:57 +0200 [thread overview]
Message-ID: <4A8A552D.6020407@viscovery.net> (raw)
From: Johannes Sixt <j6t@kdbg.org>
This is a minimal fix to compile block-sha1 on Windows. I did not do any
benchmarks whether the implementation of ntohl() is actually faster than
bytewise access and shifts.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
I would appreciate if our Windows experts could tell whether the
implementation of ntohl/htonl is worth its money or whether we should
go with the generic byte access plus shifts.
the function call over
block-sha1/sha1.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/block-sha1/sha1.c b/block-sha1/sha1.c
index a1228cf..67c1ee8 100644
--- a/block-sha1/sha1.c
+++ b/block-sha1/sha1.c
@@ -7,7 +7,11 @@
*/
#include <string.h>
+#ifndef _WIN32
#include <arpa/inet.h>
+#else
+#include <winsock2.h>
+#endif
#include "sha1.h"
--
1.6.4.1179.g9a91.dirty
next reply other threads:[~2009-08-18 7:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 7:15 Johannes Sixt [this message]
2009-08-18 10:45 ` [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Sebastian Schuberth
2009-08-18 11:07 ` Junio C Hamano
2009-08-18 11:28 ` Sebastian Schuberth
2009-08-18 12:56 ` Artur Skawina
2009-08-18 13:17 ` Sebastian Schuberth
2009-08-18 13:39 ` Junio C Hamano
2009-08-18 15:40 ` Linus Torvalds
2009-08-18 16:08 ` Linus Torvalds
2009-08-18 16:23 ` Sebastian Schuberth
2009-08-18 16:43 ` Junio C Hamano
2009-08-18 16:30 ` Nicolas Pitre
2009-08-18 16:43 ` Nicolas Pitre
2009-08-18 16:50 ` Junio C Hamano
2009-08-18 18:01 ` Nicolas Pitre
2009-08-18 19:00 ` Junio C Hamano
2009-08-18 19:22 ` Nicolas Pitre
2009-08-18 19:26 ` [PATCH] make sure byte swapping is optimal for git Nicolas Pitre
2009-08-18 19:37 ` [PATCH] block-sha1: guard gcc extensions with __GNUC__ Nicolas Pitre
2009-08-18 19:40 ` [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Junio C Hamano
2009-08-18 19:56 ` Brandon Casey
2009-08-18 20:10 ` Nicolas Pitre
2009-08-18 20:25 ` Linus Torvalds
2009-08-18 20:29 ` Brandon Casey
2009-08-20 2:26 ` Nicolas Pitre
2009-08-20 2:30 ` Linus Torvalds
2009-08-20 2:45 ` Brandon Casey
2009-08-18 16:59 ` Sebastian Schuberth
2009-08-18 17:05 ` Junio C Hamano
2009-08-18 18:16 ` Nicolas Pitre
2009-08-18 20:17 ` Junio C Hamano
2009-08-18 20:30 ` Junio C Hamano
2009-08-18 20:49 ` Nicolas Pitre
2009-08-18 18:10 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8A552D.6020407@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.