From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Nicolas Pitre <nico@cam.org>, Junio C Hamano <gitster@pobox.com>,
Artur Skawina <art.08.09@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
msysGit <msysgit@googlegroups.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h
Date: Tue, 18 Aug 2009 10:05:59 -0700 [thread overview]
Message-ID: <7vpratdpc8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <bdca99240908180959h69f37671k4d526fbf4814e8d1@mail.gmail.com> (Sebastian Schuberth's message of "Tue\, 18 Aug 2009 18\:59\:18 +0200")
Sebastian Schuberth <sschuberth@gmail.com> writes:
> I like the idea of making bswap available more globally, but I'm not
> sure if it's worth to introduce a new file for only that purpose.
> Isn't there already a central header for such things?
>
> Moreover, including compat/bswap.h would only give you ntohl()/htonl()
> on one platform.
We do not include compat/ directly from the source; git-compat-util.h is
supposed to be the first thing included (as some platforms have peculiar
requirements on the order in which system header files are included, and
one of the reasons git-compat-util.h is there). Hence by including it,
you get ntohl/htonl everywhere.
To reduce confusion, you may want to rename compat/bswap.h to something
like compat/ntohl-htonl-fix.h ;-)
next prev parent reply other threads:[~2009-08-18 17:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 7:15 [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Johannes Sixt
2009-08-18 10:45 ` Sebastian Schuberth
2009-08-18 11:07 ` Junio C Hamano
2009-08-18 11:28 ` Sebastian Schuberth
2009-08-18 12:56 ` Artur Skawina
2009-08-18 13:17 ` Sebastian Schuberth
2009-08-18 13:39 ` Junio C Hamano
2009-08-18 15:40 ` Linus Torvalds
2009-08-18 16:08 ` Linus Torvalds
2009-08-18 16:23 ` Sebastian Schuberth
2009-08-18 16:43 ` Junio C Hamano
2009-08-18 16:30 ` Nicolas Pitre
2009-08-18 16:43 ` Nicolas Pitre
2009-08-18 16:50 ` Junio C Hamano
2009-08-18 18:01 ` Nicolas Pitre
2009-08-18 19:00 ` Junio C Hamano
2009-08-18 19:22 ` Nicolas Pitre
2009-08-18 19:26 ` [PATCH] make sure byte swapping is optimal for git Nicolas Pitre
2009-08-18 19:37 ` [PATCH] block-sha1: guard gcc extensions with __GNUC__ Nicolas Pitre
2009-08-18 19:40 ` [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Junio C Hamano
2009-08-18 19:56 ` Brandon Casey
2009-08-18 20:10 ` Nicolas Pitre
2009-08-18 20:25 ` Linus Torvalds
2009-08-18 20:29 ` Brandon Casey
2009-08-20 2:26 ` Nicolas Pitre
2009-08-20 2:30 ` Linus Torvalds
2009-08-20 2:45 ` Brandon Casey
2009-08-18 16:59 ` Sebastian Schuberth
2009-08-18 17:05 ` Junio C Hamano [this message]
2009-08-18 18:16 ` Nicolas Pitre
2009-08-18 20:17 ` Junio C Hamano
2009-08-18 20:30 ` Junio C Hamano
2009-08-18 20:49 ` Nicolas Pitre
2009-08-18 18:10 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpratdpc8.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=art.08.09@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=msysgit@googlegroups.com \
--cc=nico@cam.org \
--cc=sschuberth@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.