All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-mm@kvack.org,
	Neil Horman <nhorman@redhat.com>,
	Andi Kleen <andi@firstfloor.org>,
	akpm@linux-foundation.org, bernhard.walle@gmx.de,
	Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: Re: [Patch 8/8] kexec: allow to shrink reserved memory
Date: Tue, 18 Aug 2009 08:51:27 +0000	[thread overview]
Message-ID: <4A8A6B8F.7000604@redhat.com> (raw)
In-Reply-To: <20090818172552.779d0768.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> On Tue, 18 Aug 2009 14:31:23 +0800
> Amerigo Wang <amwang@redhat.com> wrote:
>   
>> Hi, thank you!
>>     
>>> Can I have a question ?
>>>
>>>   - How crash kernel's memory is preserved at boot ?
>>>   
>>>       
>> Use bootmem, I think.
>>
>>     
> I see.
>
> In x86,
>  
>   setup_arch()
> 	-> reserve_crashkernel()
> 		-> find_and_reserve_crashkernel()
> 			-> reserve_bootmem_generic()
>
> Then, all "active range" is already registered and there are memmap.
>
>
>   
>>>     It's hidden from the system before mem_init() ?
>>>   
>>>       
>> Not sure, but probably yes. It is reserved in setup_arch() which is 
>> before mm_init() which calls mem_init().
>>
>> Do you have any advice to free that reserved memory after boot? :)
>>
>>     
>
> Let's see arch/x86/mm/init.c::free_initmem()
>
> Maybe it's all you want.
>
> 	- ClearPageReserved()
> 	- init_page_count()
> 	- free_page()
> 	- totalram_pages++
>
> But it has no argumetns. Maybe you need your own function or modification.
> online_pages() does very similar. But, hmm,.. writing something open coded one
> for crashkernel is not very bad, I think.
>   

Nice help!

Yeah, I think we can make that be a generic wrapper function so that 
both free_initmem() and shrink_crash_memory() can use it.

Then I will update and resend the whole patchset.

Thank you!




WARNING: multiple messages have this Message-ID (diff)
From: Amerigo Wang <amwang@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-mm@kvack.org,
	Neil Horman <nhorman@redhat.com>,
	Andi Kleen <andi@firstfloor.org>,
	akpm@linux-foundation.org, bernhard.walle@gmx.de,
	Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: Re: [Patch 8/8] kexec: allow to shrink reserved memory
Date: Tue, 18 Aug 2009 16:51:27 +0800	[thread overview]
Message-ID: <4A8A6B8F.7000604@redhat.com> (raw)
In-Reply-To: <20090818172552.779d0768.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> On Tue, 18 Aug 2009 14:31:23 +0800
> Amerigo Wang <amwang@redhat.com> wrote:
>   
>> Hi, thank you!
>>     
>>> Can I have a question ?
>>>
>>>   - How crash kernel's memory is preserved at boot ?
>>>   
>>>       
>> Use bootmem, I think.
>>
>>     
> I see.
>
> In x86,
>  
>   setup_arch()
> 	-> reserve_crashkernel()
> 		-> find_and_reserve_crashkernel()
> 			-> reserve_bootmem_generic()
>
> Then, all "active range" is already registered and there are memmap.
>
>
>   
>>>     It's hidden from the system before mem_init() ?
>>>   
>>>       
>> Not sure, but probably yes. It is reserved in setup_arch() which is 
>> before mm_init() which calls mem_init().
>>
>> Do you have any advice to free that reserved memory after boot? :)
>>
>>     
>
> Let's see arch/x86/mm/init.c::free_initmem()
>
> Maybe it's all you want.
>
> 	- ClearPageReserved()
> 	- init_page_count()
> 	- free_page()
> 	- totalram_pages++
>
> But it has no argumetns. Maybe you need your own function or modification.
> online_pages() does very similar. But, hmm,.. writing something open coded one
> for crashkernel is not very bad, I think.
>   

Nice help!

Yeah, I think we can make that be a generic wrapper function so that 
both free_initmem() and shrink_crash_memory() can use it.

Then I will update and resend the whole patchset.

Thank you!




WARNING: multiple messages have this Message-ID (diff)
From: Amerigo Wang <amwang@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-mm@kvack.org,
	Neil Horman <nhorman@redhat.com>,
	Andi Kleen <andi@firstfloor.org>,
	akpm@linux-foundation.org, bernhard.walle@gmx.de,
	Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: Re: [Patch 8/8] kexec: allow to shrink reserved memory
Date: Tue, 18 Aug 2009 16:51:27 +0800	[thread overview]
Message-ID: <4A8A6B8F.7000604@redhat.com> (raw)
In-Reply-To: <20090818172552.779d0768.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> On Tue, 18 Aug 2009 14:31:23 +0800
> Amerigo Wang <amwang@redhat.com> wrote:
>   
>> Hi, thank you!
>>     
>>> Can I have a question ?
>>>
>>>   - How crash kernel's memory is preserved at boot ?
>>>   
>>>       
>> Use bootmem, I think.
>>
>>     
> I see.
>
> In x86,
>  
>   setup_arch()
> 	-> reserve_crashkernel()
> 		-> find_and_reserve_crashkernel()
> 			-> reserve_bootmem_generic()
>
> Then, all "active range" is already registered and there are memmap.
>
>
>   
>>>     It's hidden from the system before mem_init() ?
>>>   
>>>       
>> Not sure, but probably yes. It is reserved in setup_arch() which is 
>> before mm_init() which calls mem_init().
>>
>> Do you have any advice to free that reserved memory after boot? :)
>>
>>     
>
> Let's see arch/x86/mm/init.c::free_initmem()
>
> Maybe it's all you want.
>
> 	- ClearPageReserved()
> 	- init_page_count()
> 	- free_page()
> 	- totalram_pages++
>
> But it has no argumetns. Maybe you need your own function or modification.
> online_pages() does very similar. But, hmm,.. writing something open coded one
> for crashkernel is not very bad, I think.
>   

Nice help!

Yeah, I think we can make that be a generic wrapper function so that 
both free_initmem() and shrink_crash_memory() can use it.

Then I will update and resend the whole patchset.

Thank you!



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-08-18  8:51 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12  8:15 [Patch 0/8] V3 Implement crashkernel=auto Amerigo Wang
2009-08-12  8:15 ` Amerigo Wang
2009-08-12  8:15 ` [Patch 1/8] x86: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-12  8:15   ` Amerigo Wang
2009-08-12  8:15 ` [Patch 2/8] x86: implement crashkernel=auto Amerigo Wang
2009-08-12  8:15   ` Amerigo Wang
2009-08-12  8:15 ` [Patch 3/8] ia64: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-12  8:15   ` Amerigo Wang
2009-08-12  8:15 ` [Patch 4/8] ia64: implement crashkernel=auto Amerigo Wang
2009-08-12  8:15   ` Amerigo Wang
2009-08-12  8:16 ` [Patch 5/8] powerpc: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-12  8:16   ` Amerigo Wang
2009-08-12  8:16 ` [Patch 6/8] powerpc: implement crashkernel=auto Amerigo Wang
2009-08-12  8:16   ` Amerigo Wang
2009-08-12  8:16 ` [Patch 7/8] doc: update the kdump document Amerigo Wang
2009-08-12  8:16   ` Amerigo Wang
2009-08-12  8:16 ` [Patch 8/8] kexec: allow to shrink reserved memory Amerigo Wang
2009-08-12  8:16   ` Amerigo Wang
2009-08-13  3:11   ` Eric W. Biederman
2009-08-13  3:11     ` Eric W. Biederman
2009-08-13  3:32     ` Amerigo Wang
2009-08-13  3:32       ` Amerigo Wang
2009-08-13  3:32       ` Amerigo Wang
2009-08-13  6:18       ` Eric W. Biederman
2009-08-13  6:18         ` Eric W. Biederman
2009-08-13  6:18         ` Eric W. Biederman
2009-08-13  8:23         ` Amerigo Wang
2009-08-13  8:23           ` Amerigo Wang
2009-08-13  8:23           ` Amerigo Wang
2009-08-14 22:17           ` Eric W. Biederman
2009-08-14 22:17             ` Eric W. Biederman
2009-08-14 22:17             ` Eric W. Biederman
2009-08-17  9:50             ` Amerigo Wang
2009-08-17  9:50               ` Amerigo Wang
2009-08-17  9:50               ` Amerigo Wang
2009-08-18  0:29               ` KAMEZAWA Hiroyuki
2009-08-18  0:29                 ` KAMEZAWA Hiroyuki
2009-08-18  0:29                 ` KAMEZAWA Hiroyuki
2009-08-18  6:31                 ` Amerigo Wang
2009-08-18  6:31                   ` Amerigo Wang
2009-08-18  6:31                   ` Amerigo Wang
2009-08-18  8:25                   ` KAMEZAWA Hiroyuki
2009-08-18  8:25                     ` KAMEZAWA Hiroyuki
2009-08-18  8:25                     ` KAMEZAWA Hiroyuki
2009-08-18  8:51                     ` Amerigo Wang [this message]
2009-08-18  8:51                       ` Amerigo Wang
2009-08-18  8:51                       ` Amerigo Wang
2009-08-18 10:35                     ` Amerigo Wang
2009-08-18 10:35                       ` Amerigo Wang
2009-08-18 10:35                       ` Amerigo Wang
2009-08-18 23:57                       ` KAMEZAWA Hiroyuki
2009-08-18 23:57                         ` KAMEZAWA Hiroyuki
2009-08-18 23:57                         ` KAMEZAWA Hiroyuki
2009-08-19  2:41                         ` Amerigo Wang
2009-08-19  2:41                           ` Amerigo Wang
2009-08-19  2:41                           ` Amerigo Wang
2009-08-19  8:13                           ` KAMEZAWA Hiroyuki
2009-08-19  8:13                             ` KAMEZAWA Hiroyuki
2009-08-19  8:13                             ` KAMEZAWA Hiroyuki
2009-08-19 10:47                             ` Amerigo Wang
2009-08-19 10:47                               ` Amerigo Wang
2009-08-19 10:47                               ` Amerigo Wang
2009-08-20  9:15                             ` Amerigo Wang
2009-08-20  9:15                               ` Amerigo Wang
2009-08-20  9:15                               ` Amerigo Wang
2009-08-21  0:34                               ` KAMEZAWA Hiroyuki
2009-08-21  0:34                                 ` KAMEZAWA Hiroyuki
2009-08-21  0:34                                 ` KAMEZAWA Hiroyuki
2009-08-21  1:59                                 ` Amerigo Wang
2009-08-21  1:59                                   ` Amerigo Wang
2009-08-21  1:59                                   ` Amerigo Wang
2009-08-21  2:03                                   ` KAMEZAWA Hiroyuki
2009-08-21  2:03                                     ` KAMEZAWA Hiroyuki
2009-08-21  2:03                                     ` KAMEZAWA Hiroyuki
2009-08-21  2:47                                     ` Amerigo Wang
2009-08-21  2:47                                       ` Amerigo Wang
2009-08-21  2:47                                       ` Amerigo Wang
2009-08-12 12:46 ` [Patch 0/8] V3 Implement crashkernel=auto Bernhard Walle
2009-08-12 12:46   ` Bernhard Walle
2009-08-13  2:49   ` Amerigo Wang
2009-08-13  2:49     ` Amerigo Wang
2009-08-13  5:39     ` Bernhard Walle
2009-08-13  5:39       ` Bernhard Walle
2009-08-13  8:19       ` Amerigo Wang
2009-08-13  8:19         ` Amerigo Wang
2009-08-13  9:03         ` Bernhard Walle
2009-08-13  9:03           ` Bernhard Walle
2009-08-13 10:49           ` Eric W. Biederman
2009-08-13 10:49             ` Eric W. Biederman
2009-08-14  2:59             ` Amerigo Wang
2009-08-14  2:59               ` Amerigo Wang
  -- strict thread matches above, loose matches on Subject: below --
2009-08-27  3:15 [Patch 0/8] V5 " Amerigo Wang
2009-08-27  3:17 ` [Patch 8/8] kexec: allow to shrink reserved memory Amerigo Wang
2009-08-27  3:17   ` Amerigo Wang
2009-09-04 10:08 [Patch 0/8] V6 Implement crashkernel=auto Amerigo Wang
2009-09-04 10:09 ` [Patch 8/8] kexec: allow to shrink reserved memory Amerigo Wang
2009-09-04 10:09   ` Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8A6B8F.7000604@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=bernhard.walle@gmx.de \
    --cc=ebiederm@xmission.com \
    --cc=fenghua.yu@intel.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=nhorman@redhat.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.