Re: [PATCH]: Implement bzip2 and LZMA loaders / fixed patch for Xen 3.4.1

[Chris Lalancette <clalance@redhat.com>]

Keir Fraser wrote:
> On 21/08/2009 10:22, "Pasi Kärkkäinen" <pasik@iki.fi> wrote:
> 
>>> Okay, I tested and fixed the stubdom case, so hopefully c/s 20104 will
>>> actually work for you.
>>>
>> xen-unstable "make tools && make stubdom" compiles for me with and without
>> libbz2-devel/liblzma-devel installed.
>>
>> But even when I have liblzma-devel installed it doesn't seem to use it.
>> ie. I only see -DHAVE_BZLIB in the build log and libxenguest.so.3.4.0 gets
>> only linked against -lbz2.
>>
>> Investigating more..
> 
> With that package installed, do you have a header /usr/include/lzma.h, or
> otherwise have lzma.h on the standard include path? If not then we're doing
> the right thing, since Chris's patch wants to #include <lzma.h>. If it is,
> then the has_header lzma.h check in the libxc Makefile is broken somehow.

Hm, there's also a somewhat confusing situation with LZMA.  I'm not sure I
completely understand it, but from what I can tell the lzma.h header file should
be coming from the new "xz" project, not from the lzma project.  That is, on my
Fedora 10 box, in order to get LZMA support compiled, I needed to install the
xz-devel package; lzma-devel was not sufficient.

-- 
Chris Lalancette