* [PATCH] gdth: unmap ccb_phys when scsi_add_host() fails in gdth_eisa_probe_one()
@ 2009-08-22 17:05 Roel Kluin
2009-08-24 20:49 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-22 17:05 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi, Andrew Morton
unmap ccb_phys as well when scsi_add_host() fails
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Right?
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 185e6bc..3111503 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -4903,7 +4903,7 @@ static int __init gdth_eisa_probe_one(ushort eisa_slot)
error = scsi_add_host(shp, NULL);
if (error)
- goto out_free_coal_stat;
+ goto out_free_ccb_phys;
list_add_tail(&ha->list, &gdth_instances);
gdth_timer_init();
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gdth: unmap ccb_phys when scsi_add_host() fails in gdth_eisa_probe_one()
2009-08-22 17:05 [PATCH] gdth: unmap ccb_phys when scsi_add_host() fails in gdth_eisa_probe_one() Roel Kluin
@ 2009-08-24 20:49 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2009-08-24 20:49 UTC (permalink / raw)
To: Roel Kluin; +Cc: James.Bottomley, linux-scsi, Achim Leubner
On Sat, 22 Aug 2009 19:05:52 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> unmap ccb_phys as well when scsi_add_host() fails
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Right?
Partially.
> diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
> index 185e6bc..3111503 100644
> --- a/drivers/scsi/gdth.c
> +++ b/drivers/scsi/gdth.c
> @@ -4903,7 +4903,7 @@ static int __init gdth_eisa_probe_one(ushort eisa_slot)
>
> error = scsi_add_host(shp, NULL);
> if (error)
> - goto out_free_coal_stat;
> + goto out_free_ccb_phys;
> list_add_tail(&ha->list, &gdth_instances);
> gdth_timer_init();
>
I suspect that we should also undo the effects of gdth_enable_int() if
taking this path.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-24 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-22 17:05 [PATCH] gdth: unmap ccb_phys when scsi_add_host() fails in gdth_eisa_probe_one() Roel Kluin
2009-08-24 20:49 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.