* [PATCH] ASoC: free socdev if init_card() fails in wm9705_soc_probe()
@ 2009-08-22 19:24 Roel Kluin
2009-08-23 9:03 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-22 19:24 UTC (permalink / raw)
To: Mark Brown, alsa-devel, Andrew Morton
Free socdev if snd_soc_init_card() fails.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
It doesn't seem to happen in snd_soc_init_card(), but please review.
diff --git a/sound/soc/codecs/wm9705.c b/sound/soc/codecs/wm9705.c
index fa88b46..e7d2840 100644
--- a/sound/soc/codecs/wm9705.c
+++ b/sound/soc/codecs/wm9705.c
@@ -406,7 +406,7 @@ static int wm9705_soc_probe(struct platform_device *pdev)
ret = snd_soc_init_card(socdev);
if (ret < 0) {
printk(KERN_ERR "wm9705: failed to register card\n");
- goto pcm_err;
+ goto reset_err;
}
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: free socdev if init_card() fails in wm9705_soc_probe()
2009-08-22 19:24 [PATCH] ASoC: free socdev if init_card() fails in wm9705_soc_probe() Roel Kluin
@ 2009-08-23 9:03 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2009-08-23 9:03 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel, Andrew Morton
On Sat, Aug 22, 2009 at 09:24:24PM +0200, Roel Kluin wrote:
> Free socdev if snd_soc_init_card() fails.
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-23 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-22 19:24 [PATCH] ASoC: free socdev if init_card() fails in wm9705_soc_probe() Roel Kluin
2009-08-23 9:03 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.