radeonfb cannot map FB

radeonfb cannot map FB

[Rui Santos]

Dear Benjamin Herrenschmidt, dear mailing list subscribers,

     I'm trying to load radeonfb for an RV100 QY chipset. Whatever I
type in the modprobe I always get:
       radeonfb (0000:01:0c.0): cannot map FB
       radeonfb: probe of 0000:01:0c.0 failed with error -5

    I've tried latest 2.6.27.x and 2.6.30.x kernels. This a secondary
video card that I would like to connect a monitor to. The first video
card is an Intel 915G, which is working with vesafb.

    Here is the output of lspci -vvv
    01:0c.0 VGA compatible controller: ATI Technologies Inc Radeon RV100
QY [Radeon 7000/VE] (prog-if 00 [VGA controller])
            Subsystem: ATI Technologies Inc Device 013b
            Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping+ SERR- FastB2B- DisINTx-
            Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium
>TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
            Interrupt: pin A routed to IRQ 18
            Region 0: Memory at d8000000 (32-bit, prefetchable) [size=128M]
            Region 1: I/O ports at dc00 [size=256]
            Region 2: Memory at fdee0000 (32-bit, non-prefetchable)
[size=64K]
            [virtual] Expansion ROM at fde00000 [disabled] [size=128K]
            Capabilities: [50] Power Management version 2
                    Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
                    Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
            Kernel modules: radeonfb

    Can you or anyone give a hint on what I might be doing wrong:
modprobe radeonfb mode_option=800x600-16 panel_yres=600
    Or could this be some kind of hardware issue ?

    Thanks a lot for your help,

Regards,

Rui Santos
http://www.ruisantos.com/

Veni, vidi, Linux!



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

Re: radeonfb cannot map FB

[Alex Deucher]

On Mon, Aug 24, 2009 at 3:45 PM, Rui Santos<rsantos@grupopie.com> wrote:
> Dear Benjamin Herrenschmidt, dear mailing list subscribers,
>
>     I'm trying to load radeonfb for an RV100 QY chipset. Whatever I
> type in the modprobe I always get:
>       radeonfb (0000:01:0c.0): cannot map FB
>       radeonfb: probe of 0000:01:0c.0 failed with error -5
>
>    I've tried latest 2.6.27.x and 2.6.30.x kernels. This a secondary
> video card that I would like to connect a monitor to. The first video
> card is an Intel 915G, which is working with vesafb.
>
>    Here is the output of lspci -vvv
>    01:0c.0 VGA compatible controller: ATI Technologies Inc Radeon RV100
> QY [Radeon 7000/VE] (prog-if 00 [VGA controller])
>            Subsystem: ATI Technologies Inc Device 013b
>            Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping+ SERR- FastB2B- DisINTx-
>            Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium
>>TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>            Interrupt: pin A routed to IRQ 18
>            Region 0: Memory at d8000000 (32-bit, prefetchable) [size=128M]
>            Region 1: I/O ports at dc00 [size=256]
>            Region 2: Memory at fdee0000 (32-bit, non-prefetchable)
> [size=64K]
>            [virtual] Expansion ROM at fde00000 [disabled] [size=128K]
>            Capabilities: [50] Power Management version 2
>                    Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-)
>                    Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>            Kernel modules: radeonfb
>
>    Can you or anyone give a hint on what I might be doing wrong:
> modprobe radeonfb mode_option=800x600-16 panel_yres=600
>    Or could this be some kind of hardware issue ?

radeonfb doesn't currently have any code to post secondary x86 cards
so they won't work unless they have been posted by the system bios.

Alex

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

Re: radeonfb cannot map FB

[Benjamin Herrenschmidt]

On Mon, 2009-08-24 at 20:45 +0100, Rui Santos wrote:
> Dear Benjamin Herrenschmidt, dear mailing list subscribers,
> 
>      I'm trying to load radeonfb for an RV100 QY chipset. Whatever I
> type in the modprobe I always get:
>        radeonfb (0000:01:0c.0): cannot map FB
>        radeonfb: probe of 0000:01:0c.0 failed with error -5

I suspect your BIOS isn't initializing the secondary card, radeonfb is
thus unable to use it.

However, you probably don't need radeonfb. X.org should be able to get
it going as a secondary just fine, but your text consoles will have to
remain on the intel.

In the long run (though it might already work with latest upstream), the
new radeon KMS should be able to initialize those.

Cheers,
Ben.

>     I've tried latest 2.6.27.x and 2.6.30.x kernels. This a secondary
> video card that I would like to connect a monitor to. The first video
> card is an Intel 915G, which is working with vesafb.
> 
>     Here is the output of lspci -vvv
>     01:0c.0 VGA compatible controller: ATI Technologies Inc Radeon RV100
> QY [Radeon 7000/VE] (prog-if 00 [VGA controller])
>             Subsystem: ATI Technologies Inc Device 013b
>             Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping+ SERR- FastB2B- DisINTx-
>             Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium
> >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>             Interrupt: pin A routed to IRQ 18
>             Region 0: Memory at d8000000 (32-bit, prefetchable) [size=128M]
>             Region 1: I/O ports at dc00 [size=256]
>             Region 2: Memory at fdee0000 (32-bit, non-prefetchable)
> [size=64K]
>             [virtual] Expansion ROM at fde00000 [disabled] [size=128K]
>             Capabilities: [50] Power Management version 2
>                     Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-)
>                     Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>             Kernel modules: radeonfb
> 
>     Can you or anyone give a hint on what I might be doing wrong:
> modprobe radeonfb mode_option=800x600-16 panel_yres=600
>     Or could this be some kind of hardware issue ?
> 
>     Thanks a lot for your help,
> 
> Regards,
> 
> Rui Santos
> http://www.ruisantos.com/
> 
> Veni, vidi, Linux!
> 


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

Re: radeonfb cannot map FB

[Rui Santos]

Benjamin Herrenschmidt wrote:
> On Mon, 2009-08-24 at 20:45 +0100, Rui Santos wrote:
>   
>> Dear Benjamin Herrenschmidt, dear mailing list subscribers,
>>
>>      I'm trying to load radeonfb for an RV100 QY chipset. Whatever I
>> type in the modprobe I always get:
>>        radeonfb (0000:01:0c.0): cannot map FB
>>        radeonfb: probe of 0000:01:0c.0 failed with error -5
>>     
>
> I suspect your BIOS isn't initializing the secondary card, radeonfb is
> thus unable to use it.
>
> However, you probably don't need radeonfb. X.org should be able to get
> it going as a secondary just fine, but your text consoles will have to
> remain on the intel.
>
> In the long run (though it might already work with latest upstream), the
> new radeon KMS should be able to initialize those.
>   
Hi Ben, sorry for the late reply ( Motherboard crash),

The system I'm trying to setup is an IBM SurePOS 500. It is supposed to
work on a FB console (no X) in order to play some Videos :)
I'm able to use a usb to vga in order to accomplish this but, using the
integrated Radeon was preferable.
So, you're saying that it is probably a BIOS related issue, not
initializing the secondary Video card. Is there anyway I can make sure
of it? If the BIOS is not initializing it properly, I may be able to
contact IBM about it.

Once again, thanks a lot for your help,
> Cheers,
>   
Regards,
> Ben.
>   
Rui

>   
>>     I've tried latest 2.6.27.x and 2.6.30.x kernels. This a secondary
>> video card that I would like to connect a monitor to. The first video
>> card is an Intel 915G, which is working with vesafb.
>>
>>     Here is the output of lspci -vvv
>>     01:0c.0 VGA compatible controller: ATI Technologies Inc Radeon RV100
>> QY [Radeon 7000/VE] (prog-if 00 [VGA controller])
>>             Subsystem: ATI Technologies Inc Device 013b
>>             Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
>> ParErr- Stepping+ SERR- FastB2B- DisINTx-
>>             Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium
>>     
>>> TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>>>       
>>             Interrupt: pin A routed to IRQ 18
>>             Region 0: Memory at d8000000 (32-bit, prefetchable) [size=128M]
>>             Region 1: I/O ports at dc00 [size=256]
>>             Region 2: Memory at fdee0000 (32-bit, non-prefetchable)
>> [size=64K]
>>             [virtual] Expansion ROM at fde00000 [disabled] [size=128K]
>>             Capabilities: [50] Power Management version 2
>>                     Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
>> PME(D0-,D1-,D2-,D3hot-,D3cold-)
>>                     Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>>             Kernel modules: radeonfb
>>
>>     Can you or anyone give a hint on what I might be doing wrong:
>> modprobe radeonfb mode_option=800x600-16 panel_yres=600
>>     Or could this be some kind of hardware issue ?
>>
>>     Thanks a lot for your help,
>>
>> Regards,
>>
>> Rui Santos
>> http://www.ruisantos.com/
>>
>> Veni, vidi, Linux!
>>
>>     
>
>
>
>
>   


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

Re: radeonfb cannot map FB

[Alex Deucher]

On Thu, Aug 27, 2009 at 7:04 AM, Rui Santos<rsantos@grupopie.com> wrote:
> Benjamin Herrenschmidt wrote:
>> On Mon, 2009-08-24 at 20:45 +0100, Rui Santos wrote:
>>
>>> Dear Benjamin Herrenschmidt, dear mailing list subscribers,
>>>
>>>      I'm trying to load radeonfb for an RV100 QY chipset. Whatever I
>>> type in the modprobe I always get:
>>>        radeonfb (0000:01:0c.0): cannot map FB
>>>        radeonfb: probe of 0000:01:0c.0 failed with error -5
>>>
>>
>> I suspect your BIOS isn't initializing the secondary card, radeonfb is
>> thus unable to use it.
>>
>> However, you probably don't need radeonfb. X.org should be able to get
>> it going as a secondary just fine, but your text consoles will have to
>> remain on the intel.
>>
>> In the long run (though it might already work with latest upstream), the
>> new radeon KMS should be able to initialize those.
>>
> Hi Ben, sorry for the late reply ( Motherboard crash),
>
> The system I'm trying to setup is an IBM SurePOS 500. It is supposed to
> work on a FB console (no X) in order to play some Videos :)
> I'm able to use a usb to vga in order to accomplish this but, using the
> integrated Radeon was preferable.
> So, you're saying that it is probably a BIOS related issue, not
> initializing the secondary Video card. Is there anyway I can make sure
> of it? If the BIOS is not initializing it properly, I may be able to
> contact IBM about it.

x86 bioses only post the primary VGA card.  For secondary cards you'll
either need to use a driver that can initialize the card itself, or
use something like vgaarb and vbetool to post the secondary card
before loading the driver.  If you would prefer to use the radeon
card, there may be an option in the bios to use the radeon card as the
primary rather than the integrated card, however, that would probably
make the integrated card unusable.

Alex

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

Re: radeonfb cannot map FB

[Rui Santos]

> x86 bioses only post the primary VGA card.  For secondary cards you'll
> either need to use a driver that can initialize the card itself, or
> use something like vgaarb and vbetool to post the secondary card
> before loading the driver.  If you would prefer to use the radeon
> card, there may be an option in the bios to use the radeon card as the
> primary rather than the integrated card, however, that would probably
> make the integrated card unusable.
>
> Alex
>   
Hi Alex,

    There is no option similar to "Init Display first" on this BIOS.
Howerver both cards must be initialized. I'm trying a radeon kernel
modesetting approach. I'll also pursue vgaarb and vbetool options.
    Thanks a lot for the information ?

Regards,
Rui

>
>
>   


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

radeonfb: cannot map FB

[Martin MOKREJŠ]

Hi,
  could someone help with radeonfb not detected under 2.4.27-rc2?
I filed this bug under the 2.6 bugzilla ... :(
http://bugzilla.kernel.org/show_bug.cgi?id=2917
Thanks
Please Cc: me in replies.
-- 
Martin Mokrejs

Re: radeonfb: cannot map FB

[Kronos]

Martin MOKREJ¦ <mmokrejs@natur.cuni.cz> ha scritto:
> Hi,
>  could someone help with radeonfb not detected under 2.4.27-rc2?
> I filed this bug under the 2.6 bugzilla ... :(
> http://bugzilla.kernel.org/show_bug.cgi?id=2917
> Thanks
> Please Cc: me in replies.

ioremap is failing. You likely have 1GB (or more) of RAM and kernel is
unable to find some space in lowmem to map the video RAM (128MB).

In 2.6 this is fixed by mapping only a small amount of video RAM (at
most 16MB).

Backport should be easy, I'll cook a patch ASAP.

Luca
-- 
Home: http://kronoz.cjb.net
Let me make your mind, leave yourself behind
Be not afraid

Re: radeonfb: cannot map FB

[Martin MOKREJŠ]

Hi,
  yes, I have one GB and SMP kernel. It's interresting that I don't
remember this bug with kernels around 2.4.23 or .24 - just a guess. If
someone would be interrwested, and can check when did it appear for the
first time. Otherwise, will be happy to get your patch. I think the
printk() lines could print out more debug info. For example the contents of
some variables which were passed to preceeding functions ... ;)
Martin

On Sun, 27 Jun 2004, Kronos wrote:

> Martin MOKREJ? <mmokrejs@natur.cuni.cz> ha scritto:
> > Hi,
> >  could someone help with radeonfb not detected under 2.4.27-rc2?
> > I filed this bug under the 2.6 bugzilla ... :(
> > http://bugzilla.kernel.org/show_bug.cgi?id=2917
> > Thanks
> > Please Cc: me in replies.
>
> ioremap is failing. You likely have 1GB (or more) of RAM and kernel is
> unable to find some space in lowmem to map the video RAM (128MB).
>
> In 2.6 this is fixed by mapping only a small amount of video RAM (at
> most 16MB).
>
> Backport should be easy, I'll cook a patch ASAP.
>
> Luca
>

-- 
Martin Mokrejs
GPG key is at http://www.natur.cuni.cz/~mmokrejs

Re: radeonfb: cannot map FB

[Kronos]

Il Sun, Jun 27, 2004 at 09:16:34PM +0200, Martin MOKREJ? ha scritto: 
> Hi,
>   yes, I have one GB and SMP kernel. It's interresting that I don't
> remember this bug with kernels around 2.4.23 or .24 - just a guess.

Hum, I see a big DRM merge in .23 but it's unrelated to the fb driver.
Nothing else. Maybe you added another PCI card that used part of the
available address space?

> If someone would be interrwested, and can check when did it appear for
> the first time. Otherwise, will be happy to get your patch. 

Patch follows. Compile with DEBUG 1 if something goes wrong.

> I think the printk() lines could print out more debug info. For
> example the contents of some variables which were passed to preceeding
> functions ... ;)

The old driver (ie. the one in 2.4 and the "old" one in 2.6) is not
developed anymore. The new reference point is the driver by BenH in 2.6.


--- linux-2.4/drivers/video/radeonfb.c.orig	2004-06-27 22:26:56.000000000 +0200
+++ linux-2.4/drivers/video/radeonfb.c	2004-06-27 22:29:49.000000000 +0200
@@ -176,7 +176,8 @@
 #define RTRACE		if(0) printk
 #endif
 
-
+#define MAX_MAPPED_VRAM (2048*2048*4)
+#define MIN_MAPPED_VRAM (1024*768*1)
 
 enum radeon_chips {
 	RADEON_QD,
@@ -499,7 +500,8 @@
 
 	short chipset;
 	unsigned char arch;
-	int video_ram;
+	unsigned int video_ram;
+	unsigned int mapped_vram;
 	u8 rev;
 	int pitch, bpp, depth;
 	int xres, yres, pixclock;
@@ -1823,8 +1825,20 @@
 		}
 	}
 
-	rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
-				  		  rinfo->video_ram);
+	if (rinfo->video_ram < rinfo->mapped_vram)
+		rinfo->mapped_vram = rinfo->video_ram;
+	else
+		rinfo->mapped_vram = MAX_MAPPED_VRAM;
+	do {
+		rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
+				  		  rinfo->mapped_vram);
+		if (rinfo->fb_base)
+			break;
+
+		RTRACE(KERN_INFO "radeonfb: cannot ioremap %dk of videoram\n", rinfo->mapped_vram);
+		rinfo->mapped_vram /= 2;
+	} while(rinfo->mapped_vram > MIN_MAPPED_VRAM);
+	
 	if (!rinfo->fb_base) {
 		printk ("radeonfb: cannot map FB\n");
 		iounmap ((void*)rinfo->mmio_base);
@@ -1835,6 +1849,7 @@
 		kfree (rinfo);
 		return -ENODEV;
 	}
+	RTRACE(KERN_INFO "radeonfb: mapped %dk videoram\n", rinfo->mapped_vram/1024);
 
 	/* currcon not yet configured, will be set by first switch */
 	rinfo->currcon = -1;
@@ -2261,7 +2276,7 @@
 	sprintf (fix->id, "ATI Radeon %s", rinfo->name);
         
         fix->smem_start = rinfo->fb_base_phys;
-        fix->smem_len = rinfo->video_ram;
+        fix->smem_len = rinfo->mapped_vram;
 
         fix->type = disp->type;
         fix->type_aux = disp->type_aux;
@@ -2429,6 +2444,9 @@
                         return -EINVAL;
         }
 
+	if (((v.xres_virtual * v.yres_virtual * nom) / den) > rinfo->mapped_vram)
+		return -EINVAL;
+
         if (radeonfb_do_maximize(rinfo, var, &v, nom, den) < 0)
                 return -EINVAL;  
                 


Luca
-- 
Home: http://kronoz.cjb.net
Carpe diem, quam minimum credula postero. (Q. Horatius Flaccus)

Re: radeonfb: cannot map FB

[Martin MOKREJŠ]

On Sun, 27 Jun 2004, Kronos wrote:

Hi,
 thanks a lot, this has fixed my bug! Below is what I got with DEBUG=1:

radeonfb_pci_register BEGIN
radeonfb: ref_clk=2700, ref_div=12, xclk=20000 from BIOS
radeonfb: probed DDR SGRAM 131072k videoram
BIOS 4 scratch = 8000008
FP_GEN_CNTL: b430085, FP2_GEN_CNTL: 8
TMDS_TRANSMITTER_CNTL: 10000041, TMDS_CNTL: 1000000, LVDS_GEN_CNTL: 8000008
DAC_CNTL: ff606002, DAC_CNTL2: 0, CRTC_GEN_CNTL: 2000200
radeonfb: detected DFP panel size from BIOS: 1280x1024
radeonfb: mapped 16384k videoram
hStart = 1328, hEnd = 1440, hTotal = 1688
vStart = 1025, vEnd = 1028, vTotal = 1066
h_total_disp = 0x9f00d2    hsync_strt_wid = 0xe052a
v_total_disp = 0x3ff0429           vsync_strt_wid = 0x30400
pixclock = 9259
freq = 10800
post div = 0x2
fb_div = 0x60
ppll_div_3 = 0x10060
Console: switching to colour frame buffer device 160x64
radeonfb: ATI Radeon 9200 Ya DDR SGRAM 128 MB
radeonfb: DVI port DFP monitor connected
radeonfb: CRT port no monitor connected
radeonfb_pci_register END

Tha card has 128MB RAM, so the driver detects size properly.
Please include this fix in new RC.
Martin

> Il Sun, Jun 27, 2004 at 09:16:34PM +0200, Martin MOKREJ? ha scritto:
> > Hi,
> >   yes, I have one GB and SMP kernel. It's interresting that I don't
> > remember this bug with kernels around 2.4.23 or .24 - just a guess.
>
> Hum, I see a big DRM merge in .23 but it's unrelated to the fb driver.
> Nothing else. Maybe you added another PCI card that used part of the
> available address space?

Definitely not. Maybe changed setting in BIOS, otherwise physically same
box. But as I said, those kernel versions were just a guess. If you want,
I'll try several old kernels ...

> > If someone would be interrwested, and can check when did it appear for
> > the first time. Otherwise, will be happy to get your patch.
>
> Patch follows. Compile with DEBUG 1 if something goes wrong.
>
> > I think the printk() lines could print out more debug info. For
> > example the contents of some variables which were passed to preceeding
> > functions ... ;)
>
> The old driver (ie. the one in 2.4 and the "old" one in 2.6) is not
> developed anymore. The new reference point is the driver by BenH in 2.6.
>
>
> --- linux-2.4/drivers/video/radeonfb.c.orig	2004-06-27 22:26:56.000000000 +0200
> +++ linux-2.4/drivers/video/radeonfb.c	2004-06-27 22:29:49.000000000 +0200
> @@ -176,7 +176,8 @@
>  #define RTRACE		if(0) printk
>  #endif
>
> -
> +#define MAX_MAPPED_VRAM (2048*2048*4)
> +#define MIN_MAPPED_VRAM (1024*768*1)
>
>  enum radeon_chips {
>  	RADEON_QD,
> @@ -499,7 +500,8 @@
>
>  	short chipset;
>  	unsigned char arch;
> -	int video_ram;
> +	unsigned int video_ram;
> +	unsigned int mapped_vram;
>  	u8 rev;
>  	int pitch, bpp, depth;
>  	int xres, yres, pixclock;
> @@ -1823,8 +1825,20 @@
>  		}
>  	}
>
> -	rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
> -				  		  rinfo->video_ram);
> +	if (rinfo->video_ram < rinfo->mapped_vram)
> +		rinfo->mapped_vram = rinfo->video_ram;
> +	else
> +		rinfo->mapped_vram = MAX_MAPPED_VRAM;
> +	do {
> +		rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
> +				  		  rinfo->mapped_vram);
> +		if (rinfo->fb_base)
> +			break;
> +
> +		RTRACE(KERN_INFO "radeonfb: cannot ioremap %dk of videoram\n", rinfo->mapped_vram);
> +		rinfo->mapped_vram /= 2;
> +	} while(rinfo->mapped_vram > MIN_MAPPED_VRAM);
> +
>  	if (!rinfo->fb_base) {
>  		printk ("radeonfb: cannot map FB\n");
>  		iounmap ((void*)rinfo->mmio_base);
> @@ -1835,6 +1849,7 @@
>  		kfree (rinfo);
>  		return -ENODEV;
>  	}
> +	RTRACE(KERN_INFO "radeonfb: mapped %dk videoram\n", rinfo->mapped_vram/1024);
>
>  	/* currcon not yet configured, will be set by first switch */
>  	rinfo->currcon = -1;
> @@ -2261,7 +2276,7 @@
>  	sprintf (fix->id, "ATI Radeon %s", rinfo->name);
>
>          fix->smem_start = rinfo->fb_base_phys;
> -        fix->smem_len = rinfo->video_ram;
> +        fix->smem_len = rinfo->mapped_vram;
>
>          fix->type = disp->type;
>          fix->type_aux = disp->type_aux;
> @@ -2429,6 +2444,9 @@
>                          return -EINVAL;
>          }
>
> +	if (((v.xres_virtual * v.yres_virtual * nom) / den) > rinfo->mapped_vram)
> +		return -EINVAL;
> +
>          if (radeonfb_do_maximize(rinfo, var, &v, nom, den) < 0)
>                  return -EINVAL;
>
>
>
> Luca
>

-- 
Martin Mokrejs
GPG key is at http://www.natur.cuni.cz/~mmokrejs

Re: radeonfb: cannot map FB

[Martin MOKREJŠ]

Hi,
  I have just tested 2.4.28-pre2 and found this patch still isn't in. Could
someone apply it to the official tree and tell me back to re-test? The fix
works fine for me some time already.
Thanks
Martin

On Sun, 27 Jun 2004, Kronos wrote:

> Il Sun, Jun 27, 2004 at 09:16:34PM +0200, Martin MOKREJ? ha scritto:
> > Hi,
> >   yes, I have one GB and SMP kernel. It's interresting that I don't
> > remember this bug with kernels around 2.4.23 or .24 - just a guess.
>
> Hum, I see a big DRM merge in .23 but it's unrelated to the fb driver.
> Nothing else. Maybe you added another PCI card that used part of the
> available address space?
>
> > If someone would be interrwested, and can check when did it appear for
> > the first time. Otherwise, will be happy to get your patch.
>
> Patch follows. Compile with DEBUG 1 if something goes wrong.
>
> > I think the printk() lines could print out more debug info. For
> > example the contents of some variables which were passed to preceeding
> > functions ... ;)
>
> The old driver (ie. the one in 2.4 and the "old" one in 2.6) is not
> developed anymore. The new reference point is the driver by BenH in 2.6.
>
>
> --- linux-2.4/drivers/video/radeonfb.c.orig	2004-06-27 22:26:56.000000000 +0200
> +++ linux-2.4/drivers/video/radeonfb.c	2004-06-27 22:29:49.000000000 +0200
> @@ -176,7 +176,8 @@
>  #define RTRACE		if(0) printk
>  #endif
>
> -
> +#define MAX_MAPPED_VRAM (2048*2048*4)
> +#define MIN_MAPPED_VRAM (1024*768*1)
>
>  enum radeon_chips {
>  	RADEON_QD,
> @@ -499,7 +500,8 @@
>
>  	short chipset;
>  	unsigned char arch;
> -	int video_ram;
> +	unsigned int video_ram;
> +	unsigned int mapped_vram;
>  	u8 rev;
>  	int pitch, bpp, depth;
>  	int xres, yres, pixclock;
> @@ -1823,8 +1825,20 @@
>  		}
>  	}
>
> -	rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
> -				  		  rinfo->video_ram);
> +	if (rinfo->video_ram < rinfo->mapped_vram)
> +		rinfo->mapped_vram = rinfo->video_ram;
> +	else
> +		rinfo->mapped_vram = MAX_MAPPED_VRAM;
> +	do {
> +		rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
> +				  		  rinfo->mapped_vram);
> +		if (rinfo->fb_base)
> +			break;
> +
> +		RTRACE(KERN_INFO "radeonfb: cannot ioremap %dk of videoram\n", rinfo->mapped_vram);
> +		rinfo->mapped_vram /= 2;
> +	} while(rinfo->mapped_vram > MIN_MAPPED_VRAM);
> +
>  	if (!rinfo->fb_base) {
>  		printk ("radeonfb: cannot map FB\n");
>  		iounmap ((void*)rinfo->mmio_base);
> @@ -1835,6 +1849,7 @@
>  		kfree (rinfo);
>  		return -ENODEV;
>  	}
> +	RTRACE(KERN_INFO "radeonfb: mapped %dk videoram\n", rinfo->mapped_vram/1024);
>
>  	/* currcon not yet configured, will be set by first switch */
>  	rinfo->currcon = -1;
> @@ -2261,7 +2276,7 @@
>  	sprintf (fix->id, "ATI Radeon %s", rinfo->name);
>
>          fix->smem_start = rinfo->fb_base_phys;
> -        fix->smem_len = rinfo->video_ram;
> +        fix->smem_len = rinfo->mapped_vram;
>
>          fix->type = disp->type;
>          fix->type_aux = disp->type_aux;
> @@ -2429,6 +2444,9 @@
>                          return -EINVAL;
>          }
>
> +	if (((v.xres_virtual * v.yres_virtual * nom) / den) > rinfo->mapped_vram)
> +		return -EINVAL;
> +
>          if (radeonfb_do_maximize(rinfo, var, &v, nom, den) < 0)
>                  return -EINVAL;
>
>
>
> Luca
>

-- 
Martin Mokrejs
GPG key is at http://www.natur.cuni.cz/~mmokrejs

Re: radeonfb: cannot map FB

[Kronos]

Il Thu, Aug 26, 2004 at 02:03:56PM +0200, Martin MOKREJ? ha scritto: 
> Hi,
>   I have just tested 2.4.28-pre2 and found this patch still isn't in. Could
> someone apply it to the official tree and tell me back to re-test? The fix
> works fine for me some time already.

The problem is that fix->smem_len is also used by the ioctl
FBIOGET_FSCREENINFO. With my patch userspace will be unable to know the
real amount of VRAM. A proper fix requires changes in the FB API; I'll
be on holiday for a couple of weeks and I'll try to make patch that's not
too intrusive.

> On Sun, 27 Jun 2004, Kronos wrote:
> 
> > Il Sun, Jun 27, 2004 at 09:16:34PM +0200, Martin MOKREJ? ha scritto:
> > > Hi,
> > >   yes, I have one GB and SMP kernel. It's interresting that I don't
> > > remember this bug with kernels around 2.4.23 or .24 - just a guess.
> >
> > Hum, I see a big DRM merge in .23 but it's unrelated to the fb driver.
> > Nothing else. Maybe you added another PCI card that used part of the
> > available address space?
> >
> > > If someone would be interrwested, and can check when did it appear for
> > > the first time. Otherwise, will be happy to get your patch.
> >
> > Patch follows. Compile with DEBUG 1 if something goes wrong.
> >
> > > I think the printk() lines could print out more debug info. For
> > > example the contents of some variables which were passed to preceeding
> > > functions ... ;)
> >
> > The old driver (ie. the one in 2.4 and the "old" one in 2.6) is not
> > developed anymore. The new reference point is the driver by BenH in 2.6.
> >
> >
> > --- linux-2.4/drivers/video/radeonfb.c.orig	2004-06-27 22:26:56.000000000 +0200
> > +++ linux-2.4/drivers/video/radeonfb.c	2004-06-27 22:29:49.000000000 +0200
> > @@ -176,7 +176,8 @@
> >  #define RTRACE		if(0) printk
> >  #endif
> >
> > -
> > +#define MAX_MAPPED_VRAM (2048*2048*4)
> > +#define MIN_MAPPED_VRAM (1024*768*1)
> >
> >  enum radeon_chips {
> >  	RADEON_QD,
> > @@ -499,7 +500,8 @@
> >
> >  	short chipset;
> >  	unsigned char arch;
> > -	int video_ram;
> > +	unsigned int video_ram;
> > +	unsigned int mapped_vram;
> >  	u8 rev;
> >  	int pitch, bpp, depth;
> >  	int xres, yres, pixclock;
> > @@ -1823,8 +1825,20 @@
> >  		}
> >  	}
> >
> > -	rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
> > -				  		  rinfo->video_ram);
> > +	if (rinfo->video_ram < rinfo->mapped_vram)
> > +		rinfo->mapped_vram = rinfo->video_ram;
> > +	else
> > +		rinfo->mapped_vram = MAX_MAPPED_VRAM;
> > +	do {
> > +		rinfo->fb_base = (unsigned long) ioremap (rinfo->fb_base_phys,
> > +				  		  rinfo->mapped_vram);
> > +		if (rinfo->fb_base)
> > +			break;
> > +
> > +		RTRACE(KERN_INFO "radeonfb: cannot ioremap %dk of videoram\n", rinfo->mapped_vram);
> > +		rinfo->mapped_vram /= 2;
> > +	} while(rinfo->mapped_vram > MIN_MAPPED_VRAM);
> > +
> >  	if (!rinfo->fb_base) {
> >  		printk ("radeonfb: cannot map FB\n");
> >  		iounmap ((void*)rinfo->mmio_base);
> > @@ -1835,6 +1849,7 @@
> >  		kfree (rinfo);
> >  		return -ENODEV;
> >  	}
> > +	RTRACE(KERN_INFO "radeonfb: mapped %dk videoram\n", rinfo->mapped_vram/1024);
> >
> >  	/* currcon not yet configured, will be set by first switch */
> >  	rinfo->currcon = -1;
> > @@ -2261,7 +2276,7 @@
> >  	sprintf (fix->id, "ATI Radeon %s", rinfo->name);
> >
> >          fix->smem_start = rinfo->fb_base_phys;
> > -        fix->smem_len = rinfo->video_ram;
> > +        fix->smem_len = rinfo->mapped_vram;
> >
> >          fix->type = disp->type;
> >          fix->type_aux = disp->type_aux;
> > @@ -2429,6 +2444,9 @@
> >                          return -EINVAL;
> >          }
> >
> > +	if (((v.xres_virtual * v.yres_virtual * nom) / den) > rinfo->mapped_vram)
> > +		return -EINVAL;
> > +
> >          if (radeonfb_do_maximize(rinfo, var, &v, nom, den) < 0)
> >                  return -EINVAL;
> >
> >
> >
> > Luca

Luca
-- 
Home: http://kronoz.cjb.net
Un apostolo vedendo Gesu` camminare sulle acque:
- Cazzo se e` buono 'sto fumo!!!