All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@bitmath.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Henrik Rydberg <rydberg@euromail.se>,
	nicolas@boichat.ch, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: applesmc: restore keyboard
Date: Mon, 24 Aug 2009 23:37:58 +0000	[thread overview]
Message-ID: <4A932456.9000500@bitmath.org> (raw)
In-Reply-To: <20090824140717.e7011b8c.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Sat, 22 Aug 2009 23:33:52 +0200
> "Henrik Rydberg" <rydberg@euromail.se> wrote:
> 
>> On resume from suspend, the driver currently resets the logical
>> state as if it was brought up from halt. This patch uses the
>> dev_pm_ops.resume method to synchronize the hardware with the
>> memorized logical state, bringing back the backlight to the level
>> prior to suspend.
> 
> What are the runtime effects of this change?
> 

My apologies, the patch has two flaws.

1) For macbook models without keyboard backlight, the resume function
will fail internally, presumably resulting in a small unnecessary delay.

2) The accelerometer does not reset properly after hibernation.

Please drop this patch from -mm, I am sending a corrected patch
with a slightly different title. Sorry about this.

Henrik

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Rydberg <rydberg@bitmath.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Henrik Rydberg <rydberg@euromail.se>,
	nicolas@boichat.ch, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: applesmc: restore keyboard backlight on resume
Date: Tue, 25 Aug 2009 01:37:58 +0200	[thread overview]
Message-ID: <4A932456.9000500@bitmath.org> (raw)
In-Reply-To: <20090824140717.e7011b8c.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Sat, 22 Aug 2009 23:33:52 +0200
> "Henrik Rydberg" <rydberg@euromail.se> wrote:
> 
>> On resume from suspend, the driver currently resets the logical
>> state as if it was brought up from halt. This patch uses the
>> dev_pm_ops.resume method to synchronize the hardware with the
>> memorized logical state, bringing back the backlight to the level
>> prior to suspend.
> 
> What are the runtime effects of this change?
> 

My apologies, the patch has two flaws.

1) For macbook models without keyboard backlight, the resume function
will fail internally, presumably resulting in a small unnecessary delay.

2) The accelerometer does not reset properly after hibernation.

Please drop this patch from -mm, I am sending a corrected patch
with a slightly different title. Sorry about this.

Henrik

  parent reply	other threads:[~2009-08-24 23:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-22 21:33 [lm-sensors] [PATCH] hwmon: applesmc: restore keyboard backlight on Henrik Rydberg
2009-08-22 21:33 ` [PATCH] hwmon: applesmc: restore keyboard backlight on resume Henrik Rydberg
2009-08-24 21:07 ` [lm-sensors] [PATCH] hwmon: applesmc: restore keyboard Andrew Morton
2009-08-24 21:07   ` [PATCH] hwmon: applesmc: restore keyboard backlight on resume Andrew Morton
2009-08-24 21:49   ` [lm-sensors] [PATCH] hwmon: applesmc: restore keyboard Henrik Rydberg
2009-08-24 21:49     ` [PATCH] hwmon: applesmc: restore keyboard backlight on resume Henrik Rydberg
2009-08-24 23:37   ` Henrik Rydberg [this message]
2009-08-24 23:37     ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A932456.9000500@bitmath.org \
    --to=rydberg@bitmath.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=nicolas@boichat.ch \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.