From: Patrick McHardy <kaber@trash.net>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] VLANs and bridge
Date: Tue, 25 Aug 2009 16:00:44 +0200 [thread overview]
Message-ID: <4A93EE8C.6040008@trash.net> (raw)
In-Reply-To: <OF7400A5E8.F4AC001F-ONC125761C.00674A25-C125761C.00679758@transmode.se>
Joakim Tjernlund wrote:
> Simon Barber <simon@superduper.net> wrote on 22/08/2009 19:12:10:
>> Looking through B.1.3 it looks like the patch would need some
>> enhancement. It provides a good basis - handling tagging/untagging and
>> filtering, but would need a way to specify the untagged vlan separately
>> for in and out.
>
> I see. Perhaps the VLAN maintainer(CC:ed) can comment too. Especially about extending
> the VLAN code to allowed several VLANs in one interface?
Just accepting additional VIDs on one VLAN device should be
a relatively trivial change, all you need to do is call
vlan_group_set_device() with the additional VIDs.
I'd suggest to add something similar to the QoS-mapping lists
in vlan_netlink.c for the additional VIDs.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: Simon Barber <simon@superduper.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [Bridge] VLANs and bridge
Date: Tue, 25 Aug 2009 16:00:44 +0200 [thread overview]
Message-ID: <4A93EE8C.6040008@trash.net> (raw)
In-Reply-To: <OF7400A5E8.F4AC001F-ONC125761C.00674A25-C125761C.00679758@transmode.se>
Joakim Tjernlund wrote:
> Simon Barber <simon@superduper.net> wrote on 22/08/2009 19:12:10:
>> Looking through B.1.3 it looks like the patch would need some
>> enhancement. It provides a good basis - handling tagging/untagging and
>> filtering, but would need a way to specify the untagged vlan separately
>> for in and out.
>
> I see. Perhaps the VLAN maintainer(CC:ed) can comment too. Especially about extending
> the VLAN code to allowed several VLANs in one interface?
Just accepting additional VIDs on one VLAN device should be
a relatively trivial change, all you need to do is call
vlan_group_set_device() with the additional VIDs.
I'd suggest to add something similar to the QoS-mapping lists
in vlan_netlink.c for the additional VIDs.
next prev parent reply other threads:[~2009-08-25 14:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 13:49 [Bridge] VLANs and bridge Joakim Tjernlund
2009-08-22 13:49 ` Joakim Tjernlund
2009-08-22 14:34 ` [Bridge] " Simon Barber
2009-08-22 14:34 ` Simon Barber
2009-08-22 15:36 ` [Bridge] " Joakim Tjernlund
2009-08-22 15:36 ` Joakim Tjernlund
[not found] ` <OF2C06F138.1BC279AE-ONC125761A.0054117B-C125761A.0055C6F1@LocalDomain>
2009-08-22 16:38 ` Joakim Tjernlund
2009-08-22 16:38 ` Joakim Tjernlund
2009-08-22 17:12 ` Simon Barber
2009-08-22 17:12 ` Simon Barber
2009-08-24 18:51 ` Joakim Tjernlund
2009-08-24 18:51 ` Joakim Tjernlund
2009-08-25 14:00 ` Patrick McHardy [this message]
2009-08-25 14:00 ` Patrick McHardy
2009-08-26 6:56 ` Joakim Tjernlund
2009-08-26 6:56 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A93EE8C.6040008@trash.net \
--to=kaber@trash.net \
--cc=bridge@lists.linux-foundation.org \
--cc=joakim.tjernlund@transmode.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.